Skip to content

Commit

Permalink
cmd/callgraph: skip TestCallgraph on the windows-arm64-10 builder
Browse files Browse the repository at this point in the history
We don't know whether this failure is due to a Go bug or a platform
bug, so we'll skip it on the one builder to reduce noise, but not the
GOOS/GOARCH as a whole. If we do not observe failures on other
windows/arm64 builders, we can perhaps chalk it up to a platform bug.
If we do observe failures on other builders, then we'll have more data
to investigate with.

For golang/go#50706

Change-Id: I52511dd4a5cff80953823d9cf901975ff4657457
Reviewed-on: https://go-review.googlesource.com/c/tools/+/379734
Trust: Bryan Mills <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>
Trust: Daniel Martí <[email protected]>
  • Loading branch information
Bryan C. Mills committed Jan 24, 2022
1 parent 135972e commit 2cc1836
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions cmd/callgraph/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ func init() {
}

func TestCallgraph(t *testing.T) {
if b := os.Getenv("GO_BUILDER_NAME"); b == "windows-arm64-10" {
t.Skipf("skipping due to suspected file corruption bug on %s builder (https://go.dev/issue/50706)", b)
}

testenv.NeedsTool(t, "go")

gopath, err := filepath.Abs("testdata")
Expand Down

0 comments on commit 2cc1836

Please sign in to comment.