Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: drop pre go1.16 versions (and unicode tables) #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thaJeztah
Copy link
Contributor

Two commits in this patch:

all: drop pre go1.16 versions (and unicode tables)

This removes most of the tables that were only supported by older go version,
which was added in c4d099d
(https://go-review.googlesource.com/83235)

I kept the "go1.16" build tag for now, but this can probably be dropped.

remove go1.16 build-tag

Remove the go1.16 build-tag, as go1.16 and before reached EOL.

Some changes were needed in the generator code, as it would otherwise
produce a new "tables.go" file instead of updating the versioned one.

This removes most of the tables that were only supported by older go version,
which was added in c4d099d
(https://go-review.googlesource.com/83235)

I kept the "go1.16" build tag for now, but this can probably be dropped.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Remove the go1.16 build-tag, as go1.16 and before reached EOL.

Some changes were needed in the generator code, as it would otherwise
produce a new "tables.go" file instead of updating the versioned one.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@gopherbot
Copy link
Contributor

This PR (HEAD: a7b35a8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/text/+/442797 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants