Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: in mkwinsyscall, add an option to specify a custom dll extension #166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ranganath42
Copy link

windows: in mkwinsyscall, add an option to specify a custom dll extension

The current implementation uses a hardcoded '.dll' extension, but some
Windows dll files have different extensions (such as .ocx, .drv).

Fixes #58337

ranganath42 and others added 2 commits June 28, 2023 14:51
…sion

The current implementation uses a hardcoded '.dll' extension, but some
Windows dll files have different extensions (such as .ocx, .drv).

Fixes #58337
@ranganath42 ranganath42 changed the title Windows mkwinsyscall ext windows: in mkwinsyscall, add an option to specify a custom dll extension Jun 28, 2023
@gopherbot
Copy link

This PR (HEAD: 9b6e537) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/506697 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/506697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 1: Run-TryBot+1

(7 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/506697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/506697.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/506697.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants