Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: export getProcessEntry #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thaJeztah
Copy link
Contributor

This function is currently copied in github.com/inconshreveable/mousetrap, which is widely used in projects (commonly as dependency for spf13/cobra).

Until recently, mousetrap had code for backward-compatibility with old Go versions, but now that that code was removed, it's a very small wrapper around getProcessEntry. Exporting this function allows it to be an even smaller wrapper (most projects would already have golang.org/x/sys as dependency in some form or another).

@gopherbot
Copy link

This PR (HEAD: 2fb76ef) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/459039 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/459039.
After addressing review feedback, remember to publish your drafts!

This function is currently copied in github.com/inconshreveable/mousetrap,
which is widely used in projects (commonly as dependency for spf13/cobra).

Until recently, mousetrap had code for backward-compatibility with old Go
versions, but now that that code was removed, it's a very small wrapper
around getProcessEntry. Exporting this function allows it to be an even
smaller wrapper (most projects would already have golang.org/x/sys as
dependency in some form or another).
@gopherbot
Copy link

This PR (HEAD: b8275de) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/459039 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Sebastiaan van Stijn:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/459039.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/459039.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/459039.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Sebastiaan van Stijn:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/459039.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants