-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys/windows/svc: Fix IsWindowsService() to be aligned with dotnet 6 #141
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: d0a68bb) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/446535 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/446535. |
Message from Alex Brainman: Patch Set 1: Run-TryBot+1 (10 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/446535. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/446535. |
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/446535. |
The current IsWindowsService() function was inherited from the legacy .NET framework and not compatible inside windows containers. We need to update it so it works inside containers. References to: dotnet/runtime#52416 Fixes golang/go#56335
Message from Guillaume Gill: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/446535. |
d0a68bb
to
e0659b9
Compare
This PR (HEAD: e0659b9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/446535 to see it. Tip: You can toggle comments from me using the |
Message from Guillaume Gill: Patch Set 1: (9 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/446535. |
The curret IsWindowsService() method was inherited from the legacy .NET fwk and not compatible inside windows containers. We need to update it to be go x/sys compatible inside containers.
Fixes #56335