protoc-gen-go: put all imports in one section #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep plugin imports and non-plugin imports in the same section, but don't try to split stdlib and non-stdlib imports into different sections. Consistent with using astutil to insert all imports from a blank slate.
|
Oops. I accidentally merged this instead of approved it. GitHub could benefit from a 1-click approve button. |
dsnet
added a commit
that referenced
this pull request
Nov 27, 2018
Keep plugin imports and non-plugin imports in the same section, but don't try to split stdlib and non-stdlib imports into different sections. Consistent with using astutil to insert all imports from a blank slate. Change-Id: Iede57a803c4a20baa1f903504df89f02b8b951c0 Cherry-Pick: github.com/golang/protobuf@7011d38ac0d201eeddff4a4085a657c3da322d75 Original-Author: Damien Neil <[email protected]> Reviewed-on: https://go-review.googlesource.com/c/151421 Reviewed-by: Damien Neil <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep plugin imports and non-plugin imports in the same section, but
don't try to split stdlib and non-stdlib imports into different
sections. Consistent with using astutil to insert all imports from a
blank slate.