protoc-gen-go: fix up generation of package names #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An earlier change inadvertendly made the import_path flag stop setting the package name. In addition, we intentionally removed the behavior where a go_package option in one file would set the package name for other generated files, in anticipation of allowing a single compilation action to generate code for many packages. This change restores the import_path behavior. It also permits a go_package option in one file to affect other files *in the same package*. (Every source file should include a go_package option, which makes this case moot, but this minimizes the amount of breaking change that we're introducing.) Also tweak assignment of import paths to allow the import_path flag to set the import path for all generated files.
dsnet
approved these changes
Apr 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier change inadvertendly made the import_path flag stop setting
the package name. In addition, we intentionally removed the behavior where
a go_package option in one file would set the package name for other
generated files, in anticipation of allowing a single compilation action
to generate code for many packages.
This change restores the import_path behavior. It also permits a go_package
option in one file to affect other files in the same package. (Every
source file should include a go_package option, which makes this case moot,
but this minimizes the amount of breaking change that we're introducing.)
Also tweak assignment of import paths to allow the import_path flag to
set the import path for all generated files.