Return errors getting extensions when formatting text,

rather than writing the error to stderr.
golang · Jun 15, 2015 · aece6fb · aece6fb
1 parent 43447c3
commit aece6fb
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/proto/text.go b/proto/text.go
@@ -41,7 +41,6 @@ import (
 	"io"
 	"log"
 	"math"
-	"os"
 	"reflect"
 	"sort"
 	"strings"
@@ -669,10 +668,7 @@ func writeExtensions(w *textWriter, pv reflect.Value) error {
 
 		pb, err := GetExtension(ep, desc)
 		if err != nil {
-			if _, err := fmt.Fprintln(os.Stderr, "proto: failed getting extension: ", err); err != nil {
-				return err
-			}
-			continue
+			return fmt.Errorf("failed getting extension: %v", err)
 		}
 
 		// Repeated extensions will appear as a slice.