Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: adjust defs for Dragonfly BSD #54

Closed
wants to merge 2 commits into from
Closed

all: adjust defs for Dragonfly BSD #54

wants to merge 2 commits into from

Conversation

tuxillo
Copy link
Contributor

@tuxillo tuxillo commented Sep 26, 2019 •
edited
Loading

  • DragonFly BSD removed RTM_OLDADD and RTM_OLDDEL
    constants on Aug 4th, 2017 and are now gone in both master
    branch and RELEASE 5.6. It also removed IPV6_IPSEC_POLICY
    constant since IPSEC was removed from base and kernel.

@tuxillo
ipv6: Remove IPSEC related constant
928d576 
- DragonFly BSD removed IPSEC on Apr, 21st 2018 so this
  IPv6 constant is now gone in both master branch and
  RELEASE 5.6.
@tuxillo
route: Remove two obsolete constants.
1f27a0e 
- DragonFly BSD removed RTM_OLDADD annd RTM_OLDDEL
  on Aug 4th, 2017 and are now gone in both master
  branch and RELEASE 5.6.
@gopherbot
Copy link
Contributor

This PR (HEAD: 1f27a0e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/197599 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@timdarbydotnet
Copy link

@tuxillo The box running the tests is mine and it's on DFBSD HEAD.

@tuxillo
Copy link
Contributor Author

tuxillo commented Sep 26, 2019

@tdfbsd do you have instructions to set this up? Maybe I can transfer the build testing to our infrastructure and ease the burden on you :)

@timdarbydotnet
Copy link

Sure :) I'll email you; there's not much to it really.

@bsiegert
Copy link

Note that the build does not "generate the go file out of the defs file" at any point. Generated files are checked in with the code. No code generation runs at build time. This ensures that you can build the same thing on all architectures. For instance, you can build a dragonfly binary on your Linux box, copy it over and have it work.

@gopherbot
Copy link
Contributor

Message from Benny Siegert:

Patch Set 1: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=f0b9faaa

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Antonio Huete Jimenez:

Patch Set 1:

Patch Set 1: Run-TryBot+1

(2 comments)

Thanks for the review. There are 2 commits in the PR I sent to Github. Both have proper commit messages, I don't know why they got melded into a single one.

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Benny Siegert:

Patch Set 1:

Patch Set 1:

Patch Set 1: Run-TryBot+1

(2 comments)

Thanks for the review. There are 2 commits in the PR I sent to Github. Both have proper commit messages, I don't know why they got melded into a single one.

The PR has been turned into a Gerrit code review thread. Gerrit works one commit at a time, so the bot has apparently squashed your two commits together and used the initial message as the CL description.

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Antonio Huete Jimenez:

Patch Set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Benny Siegert:

Patch Set 3:

The bot overwrote your description :(

Maybe you need to edit the initial message in the github PR? Can you do that?

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Benny Siegert:

Patch Set 4: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Benny Siegert:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=728ec262

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Benny Siegert:

Patch Set 4: -Code-Review

Sorry, it looks like the first line is the title of the PR? Can you rename the PR to "all: adjust defs for Dragonfly BSD" and remove that from the text?

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@tuxillo
Copy link
Contributor Author

tuxillo commented Sep 30, 2019

@bsiegert in the Go source code there is a file: vendor/golang.org/x/net/route/zsys_dragonfly.go

This file has a comment on top:

// Code generated by cmd/cgo -godefs; DO NOT EDIT.
// cgo -godefs ./route/defs_dragonfly.go

I believe zsys_dragonfly.go is generated by 'go tool cgo' and that has to be done in the target system since it's parsing system headers.

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@tuxillo tuxillo changed the title Adjust DragonFly BSD defs all: adjust defs for Dragonfly BSD Sep 30, 2019
@gopherbot
Copy link
Contributor

Message from Benny Siegert:

Patch Set 5: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=29738389

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 5: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/197599.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 30, 2019
@tuxillo @bsiegert
all: adjust defs for Dragonfly BSD
c5a3c61 
- DragonFly BSD removed RTM_OLDADD and RTM_OLDDEL
  constants on Aug 4th, 2017 and are now gone in both master
  branch and RELEASE 5.6. It also removed IPV6_IPSEC_POLICY
  constant since IPSEC was removed from base and kernel.

Change-Id: I99fbdfcb95fb276374f7b2dbd5fa30fe3f30f709
GitHub-Last-Rev: 1f27a0e
GitHub-Pull-Request: #54
Reviewed-on: https://go-review.googlesource.com/c/net/+/197599
Reviewed-by: Benny Siegert <[email protected]>
Run-TryBot: Benny Siegert <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@bsiegert
Copy link

Thank you for your patience! I just submitted this.

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/197599 has been merged.

@gopherbot gopherbot closed this Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuxillo @gopherbot @timdarbydotnet @bsiegert @googlebot