-
Notifications
You must be signed in to change notification settings - Fork 607
add support for generics for source mode #640
Conversation
Needs a bunch of tests and things still, but should not take too much more to get this working fully |
Also, still need to look into reflect support. |
i have tried to use this fork but found out that the generated mocks are simply missing the type information |
@omichels It is still a WIP progress ATM, but getting closer. I have not committed everything yet either. I will ping on the linked issue when I think the PR is in a good state and see if anyone is still having issues. Thanks for being an early tester though! |
@omichels Would you mind trying again to see if you are still seeing issues? |
Looks fine now. Thank you so much. This is our use case: "our" API, which we want to mock:
Azure sdk:
|
Hey @codyoss - Keen to give this a spin as we're being burned with some code changes - in essence we can't regenerate mocks on some services now as a common package we have uses generics internally. When I try to install with the CLI, it bombs out due to the go.mod paths not matching - there a way to force the install?
|
@steve-gray I don' think you can go install from a fork, but I could be wrong. You should be able to check out this code locally though and run As a side not I do plan on trying to get at least this PR merged sometime this week. But there are still likely a couple of edge cases and reflect mode support before I officially cut a release. |
Seems to quietly do its thing without erroring, tests are running again. Cheers @codyoss - I'll keep an eye out for the full release 🚀 |
Thanks a lot suhu |
@codyoss is there going to be a release cut at some point with this change in it to simplify the install story for people? |
Updates: #621