-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os: optimise cgo clearenv #70672
base: master
Are you sure you want to change the base?
os: optimise cgo clearenv #70672
Conversation
This PR (HEAD: a606b0f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/633515. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/633515. |
Message from Ian Lance Taylor: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/633515. |
For programs with very large environments, calling unsetenv(3) for each environment variable can be fairly expensive because of CGo overhead, but clearenv(3) is much faster. The only thing we have to track is whether GODEBUG is being unset by the operation, which can be done very quickly without resorting to doing unsetenv(3) for every variable. This change makes os.Clearenv() ~30% faster when run an environment with 1000 environment variable set (and gets better with more environment variables): cpu: AMD Ryzen 7 7840U w/ Radeon 780M Graphics │ old.txt │ new.txt │ │ sec/op │ sec/op vs base │ Env-16 213.6µ ± 1% 185.1µ ± 3% -13.32% (p=0.000 n=10) (The time taken to set up 1000 variables in this benchmark is 117.2µs, so while the naive timing is 13% the speedup for os.Clearenv() itself the speedup is from 96.4µs to 67.9µs which is ~30%.) Change-Id: I589794845854e1721e6fc5badc671474c2bbd037
a606b0f
to
71446e9
Compare
This PR (HEAD: 71446e9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/633515. Important tips:
|
Message from Aleksa Sarai: Patch Set 1: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/633515. |
Message from Ian Lance Taylor: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/633515. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-05T04:30:15Z","revision":"19cbf5e28344a2b4c3819f31ce0d98cfad575db6"} Please don’t reply on this GitHub thread. Visit golang.org/cl/633515. |
Message from Ian Lance Taylor: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/633515. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/633515. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/633515. |
Message from Ian Lance Taylor: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/633515. |
Message from Kirill Kolyshkin: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/633515. |
For programs with very large environments, calling unsetenv(3) for each
environment variable can be fairly expensive because of CGo overhead,
but clearenv(3) is much faster. The only thing we have to track is
whether GODEBUG is being unset by the operation, which can be done very
quickly without resorting to doing unsetenv(3) for every variable.
This change makes os.Clearenv() ~30% faster when run an environment with
1000 environment variable set (and gets better with more environment
variables):
(The time taken to set up 1000 variables in this benchmark is 117.2µs,
so while the naive timing is 13% the speedup for os.Clearenv() itself is
from 96.4µs to 67.9µs which is ~30%.)