runtime: utilize EVFILT_USER more effectively #70408

sobomax · 2024-11-18T08:12:04Z

Re-work kqueue_event wakeup logic to use one-shot events. In an
event of waking up a wrong thread, simply re-post the event.

This saves close to 1 system call per wakeup on average, since
chances of non-blocking poller picking it up is pretty low.

gopherbot · 2024-11-18T08:17:17Z

This PR (HEAD: a134011) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628975.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-18T08:25:35Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T08:25:36Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T08:33:27Z

Message from Maxim Sobolev:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T08:44:08Z

Message from Maxim Sobolev:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T19:53:16Z

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T02:42:56Z

Message from Andy Pan:

Patch Set 1: Commit-Queue+1 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T02:51:18Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-19T02:29:45Z","revision":"6b023c490bcc1c37c6362bb73d6aa6780be1bcfa"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T02:51:19Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T02:51:19Z

Message from Andy Pan:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T02:51:20Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

go on master (change 628975)
tools on master (commit 0c01408)

Build or test failure, click here for results.

To reproduce, try gomote repro 8730877499026496433.

Additional links for debugging:

Output for test golang.org/x/tools module

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T02:51:20Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T02:58:55Z

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T03:07:21Z

Message from Andy Pan:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T16:03:23Z

This PR (HEAD: e71c753) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628975.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-19T16:11:53Z

Message from Maxim Sobolev:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T16:30:02Z

Message from Maxim Sobolev:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T16:38:48Z

Message from Maxim Sobolev:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T16:38:48Z

Message from Andy Pan:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T17:49:03Z

Message from Ian Lance Taylor:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T19:14:21Z

Message from Maxim Sobolev:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T19:22:41Z

Message from Maxim Sobolev:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T19:39:08Z

Message from Maxim Sobolev:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T20:04:22Z

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

Re-work kqueue_event wakeup logic to use one-shot events. In an event of waking up a wrong thread, simply re-post the event. This saves close to 1 system call per wakeup on average, since chances of non-blocking poller picking it up is pretty low.

gopherbot · 2024-11-19T20:36:25Z

This PR (HEAD: e707d47) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628975.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-19T20:44:13Z

Message from Maxim Sobolev:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-19T20:52:05Z

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T18:54:28Z

Message from Maxim Sobolev:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T19:35:38Z

Message from Ian Lance Taylor:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T19:35:39Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-20T19:21:47Z","revision":"da69f7fe06e42b16e40a0bdc207a87175203691b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T19:35:39Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Copied votes on follow-up patch sets have been updated:

LUCI-TryBot-Result-1 has been copied to patch set 4 (copy condition: "changekind:NO_CODE_CHANGE").

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T19:35:40Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-20T19:27:41Z","revision":"adfa0f75c43fba10d487d3ba41435364dcc9602f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T20:00:35Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T20:00:35Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T20:00:36Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T23:13:21Z

Message from Ian Lance Taylor:

Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T23:13:21Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-20T23:02:13Z","revision":"adfa0f75c43fba10d487d3ba41435364dcc9602f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T23:28:41Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T23:28:42Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/628975.
After addressing review feedback, remember to publish your drafts!

Re-work kqueue_event wakeup logic to use one-shot events. In an event of waking up a wrong thread, simply re-post the event. This saves close to 1 system call per wakeup on average, since chances of non-blocking poller picking it up is pretty low. Change-Id: I202d0d57a31d91ac5354ea075215f647c65790d3 GitHub-Last-Rev: e707d47 GitHub-Pull-Request: #70408 Reviewed-on: https://go-review.googlesource.com/c/go/+/628975 Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>

gopherbot · 2024-11-21T16:33:47Z

This PR is being closed because golang.org/cl/628975 has been merged.

sobomax force-pushed the master branch from 972006d to a134011 Compare November 18, 2024 08:13

sobomax force-pushed the master branch from a134011 to e71c753 Compare November 19, 2024 15:55

sobomax force-pushed the master branch from e71c753 to e707d47 Compare November 19, 2024 20:31

gopherbot closed this Nov 21, 2024

runtime: utilize EVFILT_USER more effectively #70408

runtime: utilize EVFILT_USER more effectively #70408

Conversation

sobomax commented Nov 18, 2024 • edited by ianlancetaylor Loading

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 19, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 21, 2024

sobomax commented Nov 18, 2024 •

edited by ianlancetaylor

Loading