syscall: don't change local limit if prlimit used for another process #67185

lifubang · 2024-05-05T15:20:55Z

Fixes: #67184

gopherbot · 2024-05-05T15:32:15Z

This PR (HEAD: 1b3357b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583299.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-05T15:38:38Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-05T15:50:53Z

This PR (HEAD: 840b5e2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583299.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-05T16:03:26Z

Message from li Fubang:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-05T21:38:06Z

Message from Ian Lance Taylor:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

Fixes: golang#67184 Signed-off-by: lifubang <[email protected]>

gopherbot · 2024-05-06T13:33:44Z

This PR (HEAD: 4ec35da) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583299.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-06T13:53:23Z

This PR (HEAD: 3eb44a4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583299.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-06T14:06:57Z

Message from li Fubang:

Patch Set 5:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-06T23:33:51Z

Message from Ian Lance Taylor:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-07T10:43:15Z

This PR (HEAD: a80aa21) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583299.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-07T10:49:48Z

Message from li Fubang:

Patch Set 7:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-07T20:12:26Z

Message from Ian Lance Taylor:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-08T10:28:46Z

This PR (HEAD: 565a905) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583299.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-08T10:35:07Z

Message from li Fubang:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-08T20:05:00Z

Message from Ian Lance Taylor:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-08T20:05:01Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-05-08T19:55:53Z","revision":"cc5b83468bc70f342456c96b3c5b2a9f166993f5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-08T20:17:49Z

Message from Ian Lance Taylor:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-08T20:17:50Z

Message from Go LUCI:

Patch Set 8:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64 has failed with summary (view all results):

FAILURE

go on master (change 583299)

Tests failed. See all test results.

Error: shard 1: failed to run "go tool dist test -json": exit status 1

Links:

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-08T20:17:50Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-08T20:55:43Z

Message from Ian Lance Taylor:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-09T00:53:56Z

This PR (HEAD: b2bec2a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583299.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-09T01:06:53Z

Message from li Fubang:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-09T05:03:06Z

Message from Ian Lance Taylor:

Patch Set 9: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-09T05:09:53Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-05-09T04:56:44Z","revision":"b73d11759a12b5ed5337d34163e8b78cd564703f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-09T05:28:09Z

Message from Ian Lance Taylor:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-09T05:28:09Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-09T05:28:10Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-09T19:25:49Z

Message from Ian Lance Taylor:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

Signed-off-by: lifubang <[email protected]>

gopherbot · 2024-05-10T03:29:52Z

This PR (HEAD: 5eabc76) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583299.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-10T03:57:45Z

Message from li Fubang:

Patch Set 10:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T21:08:07Z

Message from Ian Lance Taylor:

Patch Set 10: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T21:08:07Z

Message from Go LUCI:

Patch Set 10:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-05-10T20:59:53Z","revision":"1294a3f1b8b64dce6e77dcfbfe89c11528eb5e5e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T21:33:29Z

Message from Ian Lance Taylor:

Patch Set 10: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T21:33:30Z

Message from Go LUCI:

Patch Set 10:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-10T21:33:30Z

Message from Go LUCI:

Patch Set 10: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/583299.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-13T21:24:44Z

This PR is being closed because golang.org/cl/583299 has been merged.

Fixes: #67184 Change-Id: Ibdf3810cbba30ae29f466f7f95f357e8512f228b GitHub-Last-Rev: 5eabc76 GitHub-Pull-Request: #67185 Reviewed-on: https://go-review.googlesource.com/c/go/+/583299 Reviewed-by: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]>

lifubang force-pushed the fix-prlimit branch from 3a0da9b to 1b3357b Compare May 5, 2024 15:25

lifubang force-pushed the fix-prlimit branch from 1b3357b to 840b5e2 Compare May 5, 2024 15:48

lifubang changed the title ~~fix a clear nofile limit cache error in syscall.prlimit~~ syscall/prlimit: fix a clear nofile limit cache error in syscall.prlimit May 5, 2024

syscall: don't change local limit if prlimit used for another process

4ce20f3

Fixes: golang#67184 Signed-off-by: lifubang <[email protected]>

lifubang force-pushed the fix-prlimit branch from 840b5e2 to 4ec35da Compare May 6, 2024 13:28

lifubang changed the title ~~syscall/prlimit: fix a clear nofile limit cache error in syscall.prlimit~~ syscall: don't change local limit if prlimit used for another process May 6, 2024

lifubang force-pushed the fix-prlimit branch from 4ec35da to 3eb44a4 Compare May 6, 2024 13:51

lifubang changed the title ~~syscall: don't change local limit if prlimit used for another process~~ syscall: don't change local limit if prlimit used for another process May 6, 2024

lifubang force-pushed the fix-prlimit branch from 3eb44a4 to a80aa21 Compare May 7, 2024 10:38

lifubang force-pushed the fix-prlimit branch from a80aa21 to 565a905 Compare May 8, 2024 10:24

lifubang force-pushed the fix-prlimit branch from 565a905 to b2bec2a Compare May 9, 2024 00:52

add tests for prlimit

5eabc76

Signed-off-by: lifubang <[email protected]>

lifubang force-pushed the fix-prlimit branch from b2bec2a to 5eabc76 Compare May 10, 2024 03:25

gopherbot closed this May 13, 2024

lifubang deleted the fix-prlimit branch October 15, 2024 05:44

syscall: don't change local limit if prlimit used for another process #67185

syscall: don't change local limit if prlimit used for another process #67185

Conversation

lifubang commented May 5, 2024 • edited Loading

gopherbot commented May 5, 2024

gopherbot commented May 5, 2024

gopherbot commented May 5, 2024

gopherbot commented May 5, 2024

gopherbot commented May 5, 2024

gopherbot commented May 6, 2024

gopherbot commented May 6, 2024

gopherbot commented May 6, 2024

gopherbot commented May 6, 2024

gopherbot commented May 7, 2024

gopherbot commented May 7, 2024

gopherbot commented May 7, 2024

gopherbot commented May 8, 2024

gopherbot commented May 8, 2024

gopherbot commented May 8, 2024

gopherbot commented May 8, 2024

gopherbot commented May 8, 2024

gopherbot commented May 8, 2024

gopherbot commented May 8, 2024

gopherbot commented May 8, 2024

gopherbot commented May 9, 2024

gopherbot commented May 9, 2024

gopherbot commented May 9, 2024

gopherbot commented May 9, 2024

gopherbot commented May 9, 2024

gopherbot commented May 9, 2024

gopherbot commented May 9, 2024

gopherbot commented May 9, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 10, 2024

gopherbot commented May 13, 2024

lifubang commented May 5, 2024 •

edited

Loading