os/exec: on Windows look for extensions in Run if not already done

[qiulaidongfeng]

CL 512155 fixed #36768, but introduced #62596.
CL 527820 fixed #62596, but meant that the code failed to look up
file extensions on Windows for a relative path.
This CL fixes that problem by recording whether it has already
looked up file extensions.
This does mean that if Path is set manually then we do not update
it with file extensions, as doing that would be racy.

Fixes #66586

[gopherbot]

This PR (HEAD: 78e0ae5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581695.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from Gopher Robot:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: fd6c529) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581695.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from qiulaidongfeng:

Patch Set 2: Commit-Queue+1

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-25T12:47:06Z","revision":"513c94fb4669854608794164d65687b1d6b0a07e"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiulaidongfeng:

Patch Set 2: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

---

FAILURE

• go on master (change 581695)
• tools on master (commit b00d49e)

Error: failed to run "make.bash": exit status 2

Links:

• "make.bash" (combined output)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiulaidongfeng:

Patch Set 4: Commit-Queue+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-25T13:00:46Z","revision":"74f07c1f2dca4e87e05e2c846a5721c2efc0986b"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiulaidongfeng:

Patch Set 4: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):

---

FAILURE

• go on master (change 581695)

Error: shard 1: failed to run "make.bat": exit status 1

Links:

• shard 1 "make.bat" (combined output)
• shard 1 build page

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: be41db8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581695.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from qiulaidongfeng:

Patch Set 5: Commit-Queue+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-25T13:27:31Z","revision":"809075a3c45077dda6dc4d9fecc402dbec7fecff"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiulaidongfeng:

Patch Set 5: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5:

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: d9ffb2d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581695.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from qiulaidongfeng:

Patch Set 6: Commit-Queue+1

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-26T08:22:57Z","revision":"d21a94e2cfa4adb969a93ad9900d863e5a40e629"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiulaidongfeng:

Patch Set 6: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiulaidongfeng:

Patch Set 6:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 16:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 197d6e4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581695.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from qiu laidongfeng2:

Patch Set 17: Commit-Queue+1

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 17:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-05-31T08:14:13Z","revision":"99c08b19a2025c6c4faa5ae0a7a312cca43ddb3d"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiu laidongfeng2:

Patch Set 17: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 17:

This CL has passed the run

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 17: LUCI-TryBot-Result+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 17:

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: b7431d6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581695.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

This PR (HEAD: dc3169f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581695.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from qiu laidongfeng2:

Patch Set 19: Commit-Queue+1

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 19:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-01T01:16:04Z","revision":"97e7d9ea4dd88941592e93daf5f1b99ff4891d2b"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiu laidongfeng2:

Patch Set 19: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 19:

This CL has passed the run

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 19: LUCI-TryBot-Result+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiu laidongfeng2:

Patch Set 19:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 19:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from qiu laidongfeng2:

Patch Set 20:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 20: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 20:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-06T00:15:06Z","revision":"9e11ea2fd2c8d40bc6af3ce5f761e9768af7ea91"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 20: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 20:

This CL has passed the run

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 20: LUCI-TryBot-Result+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/581695 has been merged.