errors: improve the godoc for Join and Unwrap #59301
Conversation
|
This PR (HEAD: 2e075a7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/480021 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/480021. |
dnephin
force-pushed
the
godoc-errors-join
branch
from
2e075a7 to
0e54a91
Compare
|
This PR (HEAD: 0e54a91) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/480021 to see it. Tip: You can toggle comments from me using the |
|
Message from Daniel Nephin: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/480021. |
|
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/480021. |
Clarify how to deconstruct the error returned by errors.Join, and how Unwrap interacts with errors.Join.
dnephin
force-pushed
the
godoc-errors-join
branch
from
0e54a91 to
7a0ec45
Compare
|
This PR (HEAD: 7a0ec45) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/480021 to see it. Tip: You can toggle comments from me using the |
|
Message from Daniel Nephin: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/480021. |
|
Message from Ian Lance Taylor: Patch Set 3: Auto-Submit+1 Code-Review+2 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/480021. |
|
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/480021. |
|
Message from Damien Neil: Patch Set 3: Code-Review+2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/480021. |
|
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/480021. |
|
Message from Daniel Nephin: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/480021. |
Document that errors returned by Join always implement Unwrap []error. Explicitly state that Unwrap does not unwrap errors with an Unwrap() []error method. Change-Id: Id610345dcf43ca54a9dde157e56c5815c5112073 GitHub-Last-Rev: 7a0ec45 GitHub-Pull-Request: #59301 Reviewed-on: https://go-review.googlesource.com/c/go/+/480021 Run-TryBot: Emmanuel Odeke <[email protected]> Auto-Submit: Emmanuel Odeke <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Damien Neil <[email protected]>
|
This PR is being closed because golang.org/cl/480021 has been merged. |
Document that errors returned by Join always implement Unwrap []error.
Explicitly state that Unwrap does not unwrap errors
with an Unwrap() []error method.