Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/modfetch/codehost: add Unwrap to custom error types #34216

Closed
wants to merge 1 commit into from

Conversation

psampaz
Copy link
Contributor

@psampaz psampaz commented Sep 10, 2019

Updates #30322

This change adds the Unwrap method to RunError and VCSError. These 2 error types are the only custom error type of the codehost that has a nested exported error.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 10, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 22b7108) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/194599 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1: Code-Review-1

These types are in internal packages. There is no reason to update them as of yet.


Please don’t reply on this GitHub thread. Visit golang.org/cl/194599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Pantelis Sampaziotis:

Patch Set 1:

Patch Set 1: Code-Review-1

These types are in internal packages. There is no reason to update them as of yet.

ok, should I close it then?


Please don’t reply on this GitHub thread. Visit golang.org/cl/194599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1:

Patch Set 1:

Patch Set 1: Code-Review-1

These types are in internal packages. There is no reason to update them as of yet.

ok, should I close it then?

Yes, let's do that.


Please don’t reply on this GitHub thread. Visit golang.org/cl/194599.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/194599 has been abandoned.

Error types are internal to cmd/go — no update is needed as of yet.

@gopherbot gopherbot closed this Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants