path/filepath: fix Win32 tests missing 'chcp' #25089
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: ceed84f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/109362 to see it. Tip: You can toggle comments from me using the |
'%SystemRoot%/System32/chcp.com' is a tool on Windows that is used to change the active code page in the console. 'go test path/filepath' can fail with: "'chcp' is not recognized as an internal or external command" The test uses a custom PATH variable but does not include '%SystemRoot%/System32'. Always append that to PATH. Updates golang#24709
neolit123
force-pushed
the
win32-test-fix-path/filepath
branch
from
ceed84f to
fac9261
Compare
|
This PR (HEAD: fac9261) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/109362 to see it. Tip: You can toggle comments from me using the |
|
Message from Gerrit Bot: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/109362. |
neolit123
changed the title
chcp
|
Message from Gerrit Bot: Uploaded patch set 3: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/109362. |
|
Message from Gerrit Bot: Uploaded patch set 4: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/109362. |
|
Message from Brad Fitzpatrick: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/109362. |
|
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=0d016a44 Please don’t reply on this GitHub thread. Visit golang.org/cl/109362. |
|
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/109362. |
|
Message from Brad Fitzpatrick: Patch Set 4: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/109362. |
|
This PR is being closed because golang.org/cl/109362 has been merged. |
'%SystemRoot%/System32/chcp.com' is a tool on Windows that is used to change the active code page in the console. 'go test path/filepath' can fail with: "'chcp' is not recognized as an internal or external command" The test uses a custom PATH variable but does not include '%SystemRoot%/System32'. Always append that to PATH. Updates #24709 Change-Id: Ib4c83ffdcc5dd6eb7bb34c07386cf2ab61dcae57 GitHub-Last-Rev: fac9261 GitHub-Pull-Request: #25089 Reviewed-on: https://go-review.googlesource.com/109362 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
'%SystemRoot%/System32/chcp.com' is a tool on Windows that
is used to change the active code page in the console.
'go test path/filepath' can fail with:
"'chcp' is not recognized as an internal or external command"
The test uses a custom PATH variable but does not include
'%SystemRoot%/System32'. Always append that to PATH.
Updates #24709