os/exec: fix Win32 tests missing 'chcp' #25088
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: c9df164) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/109361 to see it. Tip: You can toggle comments from me using the |
'%SystemRoot%/System32/chcp.com' is a tool on Windows that is used to change the active code page in the console. 'go test os/exec' can fail with: "'chcp' is not recognized as an internal or external command" The test uses a custom PATH variable but does not include '%SystemRoot%/System32'. Always append that to PATH. Updates golang#24709
|
Message from Brad Fitzpatrick: Patch Set 1: No Markdown in commit messages please. See https://github.com/golang/go/wiki/CommitMessage Please don’t reply on this GitHub thread. Visit golang.org/cl/109361. |
neolit123
force-pushed
the
win32-test-fix-os/exec
branch
from
c9df164 to
fb93052
Compare
|
This PR (HEAD: fb93052) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/109361 to see it. Tip: You can toggle comments from me using the |
|
Message from Gerrit Bot: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/109361. |
neolit123
changed the title
chcp
|
Message from Gerrit Bot: Uploaded patch set 3: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/109361. |
|
Message from Brad Fitzpatrick: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/109361. |
|
Message from Gobot Gobot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=acdb53ca Please don’t reply on this GitHub thread. Visit golang.org/cl/109361. |
|
Message from Gobot Gobot: Patch Set 3: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/109361. |
|
This PR is being closed because golang.org/cl/109361 has been merged. |
'%SystemRoot%/System32/chcp.com' is a tool on Windows that is used to change the active code page in the console. 'go test os/exec' can fail with: "'chcp' is not recognized as an internal or external command" The test uses a custom PATH variable but does not include '%SystemRoot%/System32'. Always append that to PATH. Updates #24709 Change-Id: I1ab83b326072e3f0086b391b836234bcfd8a1fb7 GitHub-Last-Rev: fb93052 GitHub-Pull-Request: #25088 Reviewed-on: https://go-review.googlesource.com/109361 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
'%SystemRoot%/System32/chcp.com' is a tool on Windows that
is used to change the active code page in the console.
'go test os/exec' can fail with:
"'chcp' is not recognized as an internal or external command"
The test uses a custom PATH variable but does not include
'%SystemRoot%/System32'. Always append that to PATH.
Updates #24709