Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: interface.Complete panics for interfaces with duplicate methods [1.20 backport] #61744

Closed
dmitshur opened this issue Aug 3, 2023 · 2 comments
Closed

go/types: interface.Complete panics for interfaces with duplicate methods [1.20 backport] #61744

dmitshur opened this issue Aug 3, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.20.8

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Aug 3, 2023

@findleyr requested issue #61737 to be considered for backport to the next 1.20 minor release.

This is a deterministic panic when correctly using the go/types API.

(Opened this issue on @gopherbot's behalf since gopherbot is waiting on #25574 to be resolved.)
@dmitshur dmitshur added the CherryPickCandidate Used during the release process for point releases label Aug 3, 2023
@gopherbot gopherbot added this to the Go1.20.8 milestone Aug 3, 2023
@dmitshur dmitshur mentioned this issue Aug 3, 2023
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/515638 mentions this issue: [release-branch.go1.20] go/types, types2: don't panic during interface completion

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 16, 2023
@gopherbot
Copy link
Contributor

Closed by merging 974a3c9 to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Aug 17, 2023
@findleyr @gopherbot
[release-branch.go1.20] go/types, types2: don't panic during interfac…
974a3c9 
…e completion

It should be possible for the importer to construct an invalid
interface, as would have been produced by type checking.

Updates #61737
Fixes #61744

Change-Id: I72e063f4f1a6205d273a623acce2ec08c34c3cc2
Reviewed-on: https://go-review.googlesource.com/c/go/+/515555
Reviewed-by: Robert Griesemer <[email protected]>
Auto-Submit: Robert Findley <[email protected]>
Reviewed-by: Olif Oftimis <[email protected]>
Run-TryBot: Robert Findley <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
(cherry picked from commit d2ee782)
Reviewed-on: https://go-review.googlesource.com/c/go/+/515638
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@golang golang locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.20.8
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @findleyr