os/signal: `warning: syscall() may go away, please rewrite code to use direct calls` on openbsd #59667

bcmills · 2023-04-17T13:42:12Z

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

(attn @golang/openbsd @4a6f656c; see also #36435)

The text was updated successfully, but these errors were encountered:

bcmills · 2023-04-17T13:45:51Z

Looks like this was fixed by CL 484555.

gopherbot · 2023-04-17T13:49:21Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-04-12 15:45 openbsd-arm64-jsing go@b7428b7c os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-1321096947/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

2023-04-13 17:28 openbsd-arm64-jsing go@b5a7f2ee os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-1776706503/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

2023-04-13 17:46 openbsd-arm64-jsing go@74c296b6 os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-2131467224/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2023-05-30T04:15:02Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-05-26 16:17 openbsd-arm64-jsing go@4c1d8bf5 os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-2708591509/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

mknyszek · 2023-05-31T19:15:01Z

CC @4a6f656c

This warning pops up in the last failure, but that's actually also a timeout. Maybe needs a new issue?

aclements · 2023-05-31T19:18:37Z

@cherrymui points out this is because os/signal/signal_cgo_test.go:TestTerminalSignal uses syscall.Syscall, which kind of unavoidably uses syscall. That suggests we either need to rewrite that test to not use syscall.Syscall (I'm not sure that's possible) or stop building it on openbsd.

bcmills · 2023-05-31T19:28:56Z

syscall.Wait4 is already defined. I guess that just leaves SYS_IOCTL, for which a wrapper could presumably be added in internal/syscall/unix?

gopherbot · 2023-08-20T16:31:45Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-08-20 05:56 openbsd-arm64-jsing go@a2ec545e os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-917651527/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2023-08-21T23:08:16Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-08-21 18:00 openbsd-arm64-jsing go@c7383441 os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-3327794622/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2023-10-25T15:04:56Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-10-18 14:06 openbsd-arm64-jsing go@045ce51b os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-1917193263/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2023-10-30T13:59:14Z

Change https://go.dev/cl/538459 mentions this issue: os/signal: use syscall.Wait4 directly in tests

Rather than using syscall.Syscall6 with SYS_WAIT4, use syscall.Wait4 directly. Updates #59667 Change-Id: I50fea3b7d10003dbc632aafd5e170a9fe96d6f42 Reviewed-on: https://go-review.googlesource.com/c/go/+/538459 Run-TryBot: Joel Sing <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Cherry Mui <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

4a6f656c · 2023-11-02T10:37:23Z

I'm going to close this as the warning: syscall() may go away, please rewrite code to use direct calls on openbsd message is just a warning. All of the failures logged come from a range of different sources, including timeouts and breakage in other parts of Go (that have since been fixed).

gopherbot · 2023-11-06T14:07:20Z

Change https://go.dev/cl/540020 mentions this issue: os/signal,syscall: avoid calling ioctl via syscall.Syscall on BSDs

gopherbot · 2023-11-24T22:11:28Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-11-22 15:50 openbsd-arm64-jsing go@37971b31 os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-1478659808/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2023-11-30T00:37:23Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-11-29 19:13 openbsd-arm64-jsing go@636c6e35 os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-1780026275/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2023-12-04T12:22:41Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-11-29 15:49 openbsd-arm64-jsing go@1908d435 os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-1313590292/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2023-12-05T22:22:16Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-12-05 17:17 openbsd-arm64-jsing go@285ef16b os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-1479236923/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2023-12-16T05:11:00Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-12-15 21:57 openbsd-arm64-jsing go@79309716 os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-1820602792/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2023-12-29T16:14:31Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-12-18 19:42 openbsd-arm64-jsing go@08bec0db os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-136164261/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2024-01-07T08:04:40Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2023-12-06 17:29 openbsd-arm64-jsing go@c80bd631 os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-12492246475020622049/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2024-02-19T23:06:29Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2024-02-19 15:44 openbsd-arm64-jsing go@cf52e709 os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-1307644512/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2024-02-28T17:47:48Z

Found new dashboard test flakes for:

#!watchflakes
post <- goos == "openbsd" && `warning: syscall\(\) may go away, please rewrite code to use direct calls`

2024-02-28 05:32 openbsd-arm64-jsing go@b8c76eff os/signal.test [build] (log)

go.go(/home/gopher/build/tmp/go-link-1182854327/go.o:(syscall.libc_syscall_trampoline.abi0)): warning: syscall() may go away, please rewrite code to use direct calls

— watchflakes

gopherbot · 2024-03-16T14:21:29Z

Change https://go.dev/cl/572155 mentions this issue: syscall: export Tc{get,set}pgrp for testing

Provide appropriate implementations of internal/syscall/unix.Tcsetpgrp and use this for runSessionLeader in os/signal/signal_cgo_test.go. This avoids calling syscall.Syscall with SYS_IOCTL on BSDs. Updates #59667 Updates #63900 Change-Id: Ifa4696bba9f1eb68e81e7103f030bc254adaf0af Reviewed-on: https://go-review.googlesource.com/c/go/+/540020 Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: David Chase <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Joel Sing <[email protected]>

bcmills added OS-OpenBSD NeedsFix The path to resolution is known, but the work has not been done. labels Apr 17, 2023

bcmills added this to the Backlog milestone Apr 17, 2023

gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 17, 2023

bcmills mentioned this issue Apr 17, 2023

Testing packages.: unrecognized failures #57995

Closed

bcmills closed this as completed Apr 17, 2023

gopherbot reopened this May 30, 2023

mknyszek added the help wanted label May 31, 2023

mknyszek assigned 4a6f656c May 31, 2023

cherrymui changed the title ~~cmd/link: warning: syscall() may go away, please rewrite code to use direct calls on openbsd~~ os/signal: warning: syscall() may go away, please rewrite code to use direct calls on openbsd Jun 1, 2023

4a6f656c closed this as completed Nov 2, 2023

gopherbot reopened this Nov 24, 2023

gopherbot closed this as completed in ac0b2f9 Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

os/signal: `warning: syscall() may go away, please rewrite code to use direct calls` on openbsd #59667

os/signal: `warning: syscall() may go away, please rewrite code to use direct calls` on openbsd #59667

bcmills commented Apr 17, 2023 •

edited

Loading

bcmills commented Apr 17, 2023

gopherbot commented Apr 17, 2023

gopherbot commented May 30, 2023

mknyszek commented May 31, 2023

aclements commented May 31, 2023

bcmills commented May 31, 2023

gopherbot commented Aug 20, 2023

gopherbot commented Aug 21, 2023

gopherbot commented Oct 25, 2023

gopherbot commented Oct 30, 2023

4a6f656c commented Nov 2, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 24, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Dec 4, 2023

gopherbot commented Dec 5, 2023

gopherbot commented Dec 16, 2023

gopherbot commented Dec 29, 2023

gopherbot commented Jan 7, 2024

gopherbot commented Feb 19, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Mar 16, 2024

os/signal: warning: syscall() may go away, please rewrite code to use direct calls on openbsd #59667

os/signal: warning: syscall() may go away, please rewrite code to use direct calls on openbsd #59667

Comments

bcmills commented Apr 17, 2023 • edited Loading

bcmills commented Apr 17, 2023

gopherbot commented Apr 17, 2023

gopherbot commented May 30, 2023

mknyszek commented May 31, 2023

aclements commented May 31, 2023

bcmills commented May 31, 2023

gopherbot commented Aug 20, 2023

gopherbot commented Aug 21, 2023

gopherbot commented Oct 25, 2023

gopherbot commented Oct 30, 2023

4a6f656c commented Nov 2, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 24, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Dec 4, 2023

gopherbot commented Dec 5, 2023

gopherbot commented Dec 16, 2023

gopherbot commented Dec 29, 2023

gopherbot commented Jan 7, 2024

gopherbot commented Feb 19, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Mar 16, 2024

os/signal: `warning: syscall() may go away, please rewrite code to use direct calls` on openbsd #59667

os/signal: `warning: syscall() may go away, please rewrite code to use direct calls` on openbsd #59667

bcmills commented Apr 17, 2023 •

edited

Loading