-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/x509: TestPlatformVerifier failures on Windows due to broken connections #56791
Comments
Found new dashboard test flakes for:
2022-11-09 03:01 windows-amd64-longtest go@b4591662 crypto/x509.TestPlatformVerifier (log)
2022-11-15 16:24 windows-amd64-longtest go@6df54215 crypto/x509.TestPlatformVerifier (log)
|
(attn @golang/windows, @rolandshoemaker; compare #52108) |
Found new dashboard test flakes for:
2022-11-18 23:57 windows-amd64-longtest go@4f0d3bcd crypto/x509.TestPlatformVerifier (log)
|
I think this is probably related to #55050. |
HOw to handle this issue . Currently i am facing this with go 1.20 on windows 10 |
Found new dashboard test flakes for:
2023-08-18 17:06 darwin-amd64-longtest go@795e7796 crypto/x509.TestPlatformVerifierLegacy (log)
|
Found new dashboard test flakes for:
2023-10-09 21:56 windows-amd64-longtest go@5955a03e crypto/x509.TestPlatformVerifierLegacy (log)
|
Found new dashboard test flakes for:
2023-10-09 22:05 windows-amd64-longtest go@8f61fab6 crypto/x509.TestPlatformVerifierLegacy (log)
2023-10-09 22:06 windows-amd64-longtest go@51bdd3bd crypto/x509.TestPlatformVerifierLegacy (log)
|
Found new dashboard test flakes for:
2023-10-09 18:53 darwin-amd64-longtest go@a8ca649b crypto/x509.TestPlatformVerifierLegacy (log)
|
Found new dashboard test flakes for:
2023-10-10 16:10 windows-amd64-longtest go@24ae2d92 crypto/x509.TestPlatformVerifierLegacy (log)
|
Found new dashboard test flakes for:
2023-10-10 16:50 windows-amd64-longtest go@1493dd3c crypto/x509.TestPlatformVerifierLegacy (log)
|
Found new dashboard test flakes for:
2023-10-10 16:18 windows-amd64-longtest go@e175f27f crypto/x509.TestPlatformVerifier (log)
2023-10-10 16:26 windows-amd64-longtest go@8042fd87 crypto/x509.TestPlatformVerifier (log)
|
Found new dashboard test flakes for:
2023-10-10 18:10 windows-amd64-longtest go@9465990e crypto/x509.TestPlatformVerifierLegacy (log)
|
Change https://go.dev/cl/548976 mentions this issue: |
Found new dashboard test flakes for:
2023-12-11 21:37 windows-amd64-longtest go@c22781cb crypto/x509.TestPlatformVerifierLegacy (log)
|
Found new dashboard test flakes for:
2023-12-15 18:08 windows-amd64-longtest go@796f59df crypto/x509.TestPlatformVerifierLegacy (log)
|
Found new dashboard test flakes for:
2024-02-17 06:03 windows-amd64-longtest go@86a32d6d crypto/x509.TestPlatformVerifierLegacy (log)
|
Found new dashboard test flakes for:
2024-02-20 06:04 windows-amd64-longtest go@d42cd452 crypto/x509.TestPlatformVerifierLegacy (log)
|
Closed the wrong issue 🤦, should have been #65626. |
Oh wait, no, this is also Legacy. |
Found new dashboard test flakes for:
2024-02-20 06:04 gotip-windows-amd64-longtest go@d42cd452 crypto/x509.TestPlatformVerifierLegacy/expired_leaf (log)
2024-02-20 06:04 gotip-windows-amd64-longtest go@d42cd452 crypto/x509.TestPlatformVerifierLegacy/self-signed_leaf (log)
|
Found new dashboard test flakes for:
2024-05-06 21:02 windows-amd64-longtest go@947e43e3 crypto/x509.TestPlatformVerifierLegacy (log)
2024-05-06 21:03 windows-amd64-longtest go@78d89b2b crypto/x509.TestPlatformVerifierLegacy (log)
|
Found new dashboard test flakes for:
2024-05-06 21:02 go1.22-windows-amd64-longtest release-branch.go1.22@947e43e3 crypto/x509.TestPlatformVerifierLegacy/self-signed_leaf (log)
2024-05-06 21:02 go1.22-windows-amd64-longtest release-branch.go1.22@947e43e3 crypto/x509.TestPlatformVerifierLegacy/wrong_host_for_leaf (log)
2024-05-06 21:03 go1.21-windows-amd64-longtest release-branch.go1.21@78d89b2b crypto/x509.TestPlatformVerifierLegacy/wrong_host_for_leaf (log)
|
Found new dashboard test flakes for:
2024-05-13 21:10 windows-amd64-longtest go@d4a81ec7 crypto/x509.TestPlatformVerifierLegacy (log)
|
Found new dashboard test flakes for:
2024-05-13 21:10 go1.22-windows-amd64-longtest release-branch.go1.22@d4a81ec7 crypto/x509.TestPlatformVerifierLegacy/expired_leaf (log)
2024-05-13 21:10 go1.22-windows-amd64-longtest release-branch.go1.22@d4a81ec7 crypto/x509.TestPlatformVerifierLegacy/self-signed_leaf (log)
2024-05-13 21:10 go1.22-windows-amd64-longtest release-branch.go1.22@d4a81ec7 crypto/x509.TestPlatformVerifierLegacy/wrong_host_for_leaf (log)
|
@gopherbot please open backport issues for this. It's an incredibly noisy test which is currently only failing on the release branches. Those branches currently have the better tests enabled, so we should just backport https://go.dev/cl/548976 and remove these old broken ones to make the builders happy. |
Backport issue(s) opened: #67351 (for 1.21), #67352 (for 1.22). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases. |
Found new dashboard test flakes for:
2024-05-13 21:10 go1.21-windows-amd64-longtest release-branch.go1.21@0fa334d4 crypto/x509.TestPlatformVerifierLegacy/wrong_host_for_leaf (log)
|
Change https://go.dev/cl/586215 mentions this issue: |
Change https://go.dev/cl/586235 mentions this issue: |
…y tests They are no longer necessary, woohoo! Updates #52108 Fixes #56791 Fixes #67351 Change-Id: I11a4c17162da4295309f74f2f8362bab0f506f78 Reviewed-on: https://go-review.googlesource.com/c/go/+/548976 Run-TryBot: Roland Shoemaker <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Roland Shoemaker <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> (cherry picked from commit c1828fb) Reviewed-on: https://go-review.googlesource.com/c/go/+/586215 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
…y tests They are no longer necessary, woohoo! Updates #52108 Fixes #56791 Fixes #67352 Change-Id: I11a4c17162da4295309f74f2f8362bab0f506f78 Reviewed-on: https://go-review.googlesource.com/c/go/+/548976 Run-TryBot: Roland Shoemaker <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Roland Shoemaker <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> (cherry picked from commit c1828fb) Reviewed-on: https://go-review.googlesource.com/c/go/+/586235 Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Going to close this under the assumption that we should no longer see these failures. |
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: