Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: turn off github issues for oauth2 repo #56402

Open
seankhliao opened this issue Oct 24, 2022 · 12 comments
Open

github: turn off github issues for oauth2 repo #56402

seankhliao opened this issue Oct 24, 2022 · 12 comments
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@seankhliao
Copy link
Member

the github mirror repo for golang.org/x/oauth2 has issues turned on but nobody ever looks at those (nor do approvers have access to clean them up).

I think issues should be disabled, and people can continue to use the main (go) issue tracker for bugs.

cc @golang/release

@seankhliao seankhliao added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 24, 2022
@seankhliao seankhliao added this to the Unreleased milestone Oct 24, 2022
@heschi
Copy link
Contributor

heschi commented Oct 24, 2022

@codyoss is the primary maintainer of oauth2, from what I've seen. Cody, what would you like to happen here?

@codyoss
Copy link
Member

codyoss commented Oct 24, 2022

@heschi I took some maintainer bits there to oversee the google subdirectory there where some of the core auth logic is for the google cloud client libraries. Other than that I don't really do anything there. I definitely don't look at the issue tracker today, nor have the bandwidth to do so.

@mvdan
Copy link
Member

mvdan commented Oct 25, 2022

The bottom of the README does say the issue tracker is used, though. So at least it was on purpose at some point when the repository was well maintained.

@heschi heschi self-assigned this Oct 25, 2022
@heschi heschi moved this to Planned in Go Release Oct 25, 2022
@heschi
Copy link
Contributor

heschi commented Oct 25, 2022

We have agreement in principle from @golang/security that issues should be shut down on that repo. Up to them to decide when and how to do it and I'll be happy to assist with GitHub changes.

@heschi heschi removed their assignment Oct 25, 2022
@heschi heschi removed this from Go Release Oct 25, 2022
@hickford
Copy link

hickford commented Jan 3, 2023

In the meantime, to address

nor do approvers have access to clean them up

It would help to add team https://github.com/orgs/golang/teams/go-assignees as a collaborator at https://github.com/golang/oauth2/settings/access consistent with https://github.com/golang/go/wiki/GithubAccess

The poorly named "go-approvers" group is the set of people who can edit metadata on issues.

@heschi
Copy link
Contributor

heschi commented Jan 3, 2023

Makes sense to me. Done. If anyone objects I'll undo it.

@hickford
Copy link

hickford commented Jan 6, 2023

https://dev.golang.org/owners records the primary x/oauth2 code owner as @bradfitz. Secondary owners are @rakyll @broady @shinfan @codyoss. The responsibilities of code owners aren't documented. It looks like reviews are automatically assigned to the primary owner.

There are many open reviews https://go-review.googlesource.com/q/project:oauth2+status:open but the code owners are inactive:

Remove oauth2 owners inactive since 2021

Reviews are automatically assigned to owners , see #56402 (comment)

@hickford
Copy link

hickford commented Jan 21, 2023

Where should proposals for x/oauth2 be opened? This isn't obvious from the readme. I think it has to be https://github.com/golang/go/issues so that the proposal isn't missed.

@ianlancetaylor
Copy link
Contributor

Yes.

@andig
Copy link
Contributor

andig commented Jul 18, 2023

@seankhliao given #61401 has been marked as duplicate is that an encouragement to re-open issues here? If yes: could we request individual issues to be migrated (rather than written again)? Should be straightforward using Github UI afaik.

@andig
Copy link
Contributor

andig commented Jul 18, 2023

I think issues should be disabled, and people can continue to use the main (go) issue tracker for bugs.

This should be done asap. After 5 years of coding Go and various issues and comments in that repo it didn't even occur to me that it was abandoned. What is missing to make this decision?

@thepudds
Copy link
Contributor

thepudds commented Aug 9, 2023

Minor, but it would be nice to set up a codereview.cfg in the oauth2 repo when this happens (example).

@andig (or anyone else), if you are interested in slightly nudging this issue along, you could consider sending a CL that adds a codereview.cfg there, but of course no worries if not interested in that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

8 participants