-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls/test: TestCommandLine failures #55201
Comments
Found new matching flaky dashboard failures for:
2022-08-11 13:46 aix-ppc64 tools@38074195 go@2340d371 golang.org/x/tools/gopls/test.TestCommandLine (log)
|
Stopped. |
Found new dashboard test flakes for:
2022-09-28 16:54 linux-amd64-bullseye tools@bddb3720 go@d6ca2447 x/tools/gopls/test.TestCommandLine (log)
|
Found new dashboard test flakes for:
2022-10-05 16:05 darwin-amd64-10_15 tools@2d32e152 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 16:05 freebsd-amd64-race tools@2d32e152 go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 16:05 freebsd-amd64-race tools@2d32e152 go@47a53884 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 16:05 openbsd-amd64-70 tools@2d32e152 go@97d38f30 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 16:05 windows-amd64-race tools@2d32e152 go@3a37b112 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 17:57 windows-amd64-race tools@ff4ff8bf go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 17:59 freebsd-amd64-race tools@b280e27d go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 17:59 freebsd-amd64-race tools@b280e27d go@3a37b112 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 18:20 freebsd-amd64-race tools@33c2dbf3 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 18:20 windows-amd64-race tools@33c2dbf3 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 20:30 freebsd-amd64-race tools@98560770 go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 20:30 windows-amd64-race tools@98560770 go@881a1654 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 20:32 windows-amd64-race tools@d96b2388 go@0bf7ee99 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 20:32 windows-amd64-race tools@d96b2388 go@881a1654 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 23:17 freebsd-amd64-race tools@2f572702 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 23:17 windows-amd64-race tools@2f572702 go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 23:17 freebsd-amd64-race tools@4ef38dc8 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 23:17 windows-amd64-race tools@4ef38dc8 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 23:17 windows-amd64-race tools@4ef38dc8 go@0bf7ee99 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 23:17 freebsd-amd64-race tools@dc3cf95c go@af668c68 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 23:17 illumos-amd64 tools@dc3cf95c go@0bf7ee99 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 23:17 windows-amd64-race tools@dc3cf95c go@af668c68 x/tools/gopls/test.TestCommandLine (log)
2022-10-05 23:17 windows-amd64-race tools@dc3cf95c go@0bf7ee99 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 13:48 freebsd-amd64-race tools@ede3ab26 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 13:48 freebsd-amd64-race tools@ede3ab26 go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 13:48 openbsd-amd64-70 tools@ede3ab26 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 14:25 freebsd-amd64-race tools@bd8c28ff go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 14:25 windows-amd64-race tools@bd8c28ff go@9dfadf91 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 14:25 windows-amd64-race tools@bd8c28ff go@af668c68 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 16:57 freebsd-amd64-race tools@c4f49e40 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 16:57 windows-amd64-race tools@c4f49e40 go@9dfadf91 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 16:57 windows-amd64-race tools@c4f49e40 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 17:35 dragonfly-amd64-622 tools@15525299 go@274d3a06 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 17:35 freebsd-amd64-race tools@15525299 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 17:35 windows-amd64-race tools@15525299 go@274d3a06 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 17:35 windows-amd64-race tools@15525299 go@9dfadf91 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 18:44 freebsd-amd64-race tools@c6825558 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 18:44 openbsd-amd64-70 tools@c6825558 go@515e3de2 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 18:44 windows-amd64-race tools@c6825558 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 18:44 windows-amd64-race tools@c6825558 go@274d3a06 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 21:06 freebsd-amd64-race tools@778f9457 go@515e3de2 x/tools/gopls/test.TestCommandLine (log)
2022-10-06 21:06 windows-amd64-race tools@778f9457 go@d0b0b10b x/tools/gopls/test.TestCommandLine (log)
2022-10-06 21:06 windows-amd64-race tools@778f9457 go@fdea8e21 x/tools/gopls/test.TestCommandLine (log)
2022-10-07 14:24 windows-amd64-race tools@60ddccae go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-07 14:48 windows-amd64-race tools@f2c4579a go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-07 15:16 freebsd-amd64-race tools@a410e98a go@5ca0cd3f x/tools/gopls/test.TestCommandLine (log)
2022-10-07 15:16 freebsd-amd64-race tools@a410e98a go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-07 17:27 freebsd-amd64-race tools@709f1082 go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-07 17:27 openbsd-amd64-70 tools@709f1082 go@747e1961 x/tools/gopls/test.TestCommandLine (log)
2022-10-07 17:27 windows-amd64-race tools@709f1082 go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-07 17:55 freebsd-amd64-race tools@20c1ee70 go@c4674e01 x/tools/gopls/test.TestCommandLine (log)
2022-10-07 17:55 freebsd-amd64-race tools@20c1ee70 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-07 17:55 windows-amd64-race tools@20c1ee70 go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 16:03 windows-amd64-race tools@cd0288ff go@0f64a494 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 16:22 freebsd-amd64-race tools@49b340b3 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 16:22 freebsd-amd64-race tools@49b340b3 go@0f64a494 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 16:22 openbsd-amd64-70 tools@49b340b3 go@f1e50a16 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 16:22 windows-amd64-race tools@49b340b3 go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 18:07 freebsd-amd64-race tools@29429f53 go@01604129 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 18:07 freebsd-amd64-race tools@29429f53 go@f1e50a16 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 18:07 windows-amd64-race tools@29429f53 go@01604129 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 18:07 windows-amd64-race tools@29429f53 go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 20:40 freebsd-amd64-race tools@ab79327e go@140bc244 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 20:40 freebsd-amd64-race tools@ab79327e go@2dbc5736 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 20:40 freebsd-amd64-race tools@ab79327e go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 20:40 freebsd-amd64-race tools@ab79327e go@b6e7e162 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 20:40 windows-amd64-race tools@ab79327e go@2dbc5736 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 21:42 freebsd-amd64-race tools@19a5504f go@28a6f9cf x/tools/gopls/test.TestCommandLine (log)
2022-10-11 21:42 freebsd-amd64-race tools@19a5504f go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-11 21:42 windows-amd64-race tools@19a5504f go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-12 14:51 freebsd-amd64-race tools@b20ae4bc go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-12 14:51 freebsd-amd64-race tools@b20ae4bc go@28a6f9cf x/tools/gopls/test.TestCommandLine (log)
2022-10-12 14:51 windows-amd64-race tools@b20ae4bc go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-12 18:24 freebsd-amd64-race tools@d3752388 go@1a7f08cf x/tools/gopls/test.TestCommandLine (log)
2022-10-12 18:24 freebsd-amd64-race tools@d3752388 go@6a2a11fc x/tools/gopls/test.TestCommandLine (log)
2022-10-12 18:24 freebsd-amd64-race tools@d3752388 go@e0d01b84 x/tools/gopls/test.TestCommandLine (log)
2022-10-12 18:24 openbsd-386-70 tools@d3752388 go@89566448 x/tools/gopls/test.TestCommandLine (log)
2022-10-12 18:24 windows-amd64-race tools@d3752388 go@9ec69908 x/tools/gopls/test.TestCommandLine (log)
2022-10-12 18:24 windows-amd64-race tools@d3752388 go@89566448 x/tools/gopls/test.TestCommandLine (log)
|
Found new dashboard test flakes for:
2022-10-07 14:24 freebsd-amd64-race tools@60ddccae go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-12 18:24 freebsd-amd64-race tools@d3752388 go@6f445a9d x/tools/gopls/test.TestCommandLine (log)
2022-10-12 18:24 windows-amd64-race tools@d3752388 go@6f445a9d x/tools/gopls/test.TestCommandLine (log)
2022-10-13 15:07 freebsd-amd64-race tools@b2533141 go@4a0ce469 x/tools/gopls/test.TestCommandLine (log)
2022-10-13 15:07 freebsd-amd64-race tools@b2533141 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-13 15:07 illumos-amd64 tools@b2533141 go@4a0ce469 x/tools/gopls/test.TestCommandLine (log)
2022-10-13 16:31 freebsd-amd64-race tools@f87c1ed9 go@4a0ce469 x/tools/gopls/test.TestCommandLine (log)
|
Found new dashboard test flakes for:
2022-10-13 16:31 freebsd-amd64-race tools@f87c1ed9 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
|
Found new dashboard test flakes for:
2022-10-13 17:41 freebsd-amd64-race tools@ffb862b5 go@f2acc607 x/tools/gopls/test.TestCommandLine (log)
2022-10-13 17:41 freebsd-amd64-race tools@ffb862b5 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
|
Found new dashboard test flakes for:
2022-10-13 17:41 freebsd-amd64-race tools@ffb862b5 go@36ca37f3 x/tools/gopls/test.TestCommandLine (log)
2022-10-13 17:41 freebsd-amd64-race tools@ffb862b5 go@1ef685fb x/tools/gopls/test.TestCommandLine (log)
|
Found new dashboard test flakes for:
2022-10-13 17:41 openbsd-amd64-70 tools@ffb862b5 go@36ca37f3 x/tools/gopls/test.TestCommandLine (log)
|
Found new dashboard test flakes for:
2022-10-13 17:41 windows-amd64-race tools@ffb862b5 go@9fe17a03 x/tools/gopls/test.TestCommandLine (log)
|
Found new dashboard test flakes for:
2022-10-13 17:41 freebsd-amd64-race tools@ffb862b5 go@379a49c5 x/tools/gopls/test.TestCommandLine (log)
|
Found new dashboard test flakes for:
2022-10-13 17:41 freebsd-amd64-race tools@ffb862b5 go@005c78d8 x/tools/gopls/test.TestCommandLine (log)
|
This is a known issue that we're actively debugging. We can disable the consistency check that leads to this failure mode, but would rather fix the core bug. |
Ok, we understand it now, and have an idea for a fix. We'll fix this tomorrow. |
Feel free to leave open. The bot is going to keep posting, but you can ignore that. |
Change https://go.dev/cl/442794 mentions this issue: |
We now understand the longstanding race causing panics in gopls analysis (the cache key for analysis handles is not correct, and can lead to cache hits for analysis of stale packages). It will take a little while to redesign our analysis caching, the simplest solution being to hang analysis results off of the actual package they are analyzing. In the meantime, suppress the panic as before, to eliminate flakes. For golang/go#55201 For golang/go#56035 Change-Id: I96600f186f9f31b67dae10c0a95a14fa73630571 Reviewed-on: https://go-review.googlesource.com/c/tools/+/442794 Run-TryBot: Robert Findley <[email protected]> Reviewed-by: Alan Donovan <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Found new dashboard test flakes for:
2022-10-13 16:31 darwin-amd64-12_0 tools@f87c1ed9 go@947091d3 x/tools/gopls/test.TestCommandLine (log)
2022-10-13 16:31 windows-amd64-race tools@f87c1ed9 go@f2acc607 x/tools/gopls/test.TestCommandLine (log)
|
We believe https://go.dev/cl/443100 (submitted at 1.58pm ET today) should have fixed this crash. Shortly before that, we submitted https://go.dev/cl/442794 to temporarily suppress panics; and we will soon submit https://go.dev/cl/443340 to revert that, since we believe the panics are fixing. Closing this issue now, but please re-open it if any future flakes appear in these tests. |
Found new dashboard test flakes for:
2023-01-18 02:12 aix-ppc64 tools@5bedd861 go@7026a8a1 x/tools/gopls/test.TestCommandLine (log)
|
This was reopened due to #57900. |
Found new dashboard test flakes for:
2023-01-17 18:50 aix-ppc64 tools@d958e854 go@dbe327a6 x/tools/gopls/test.TestCommandLine (log)
2023-01-17 18:50 aix-ppc64 tools@d958e854 go@f773bef9 x/tools/gopls/test.TestCommandLine (log)
2023-01-17 23:21 aix-ppc64 tools@f3e53e5c go@7e740f91 x/tools/gopls/test.TestCommandLine (log)
2023-01-18 02:12 aix-ppc64 tools@5bedd861 go@581603cb x/tools/gopls/test.TestCommandLine (log)
2023-01-18 14:54 aix-ppc64 tools@f0e2d5c5 go@7026a8a1 x/tools/gopls/test.TestCommandLine (log)
2023-01-18 14:59 aix-ppc64 tools@957bec5a go@7026a8a1 x/tools/gopls/test.TestCommandLine (log)
2023-01-18 15:15 aix-ppc64 tools@2fa6ca1e go@7026a8a1 x/tools/gopls/test.TestCommandLine (log)
|
Bug automatically created to track these flakes.
— watchflakes
The text was updated successfully, but these errors were encountered: