Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relui: improve layout for results and outputs #53382

Closed
toothrot opened this issue Jun 14, 2022 · 11 comments
Closed

x/build/cmd/relui: improve layout for results and outputs #53382

toothrot opened this issue Jun 14, 2022 · 11 comments
Assignees
@toothrot
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

Task and Workflow results are formatted as json in relui. We should format them as a table or dictionary where appropriate in the UI, in order for it to be usable and not completely break the layout for large results (such as artifacts).
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 14, 2022
@toothrot toothrot added this to the Unreleased milestone Jun 14, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 14, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/412176 mentions this issue: internal/relui: simplify rendering of homepage

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/412177 mentions this issue: internal/relui: format javascript and css

gopherbot pushed a commit to golang/build that referenced this issue Jun 15, 2022
@toothrot
internal/relui: simplify rendering of homepage
2838fbb 
This refactors the homepage rendering to use a nested template for each
task row. This will help simplify the template as we add more complex
layout to the outputs of workflows and tasks.

Updates golang/go#51797
Updates golang/go#40279
For golang/go#53382

Change-Id: I85a86b82bdc79c7fb4e837d884af922c7028295d
Reviewed-on: https://go-review.googlesource.com/c/build/+/412176
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Alex Rakoczy <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/412677 mentions this issue: internal/relui: improve task result formatting

gopherbot pushed a commit to golang/build that referenced this issue Jun 16, 2022
@toothrot @gopherbot
internal/relui: format javascript and css
66dff59 
This change adds eslint and stylelint to format javascript and css
files. The configuration is based on x/pkgsite and x/website, but
removing line-length rules and typescript plugins.

For golang/go#53382

Change-Id: I4bd8a9d23fb8d7369221f455095b26734981bc54
Reviewed-on: https://go-review.googlesource.com/c/build/+/412177
Run-TryBot: Alex Rakoczy <[email protected]>
Auto-Submit: Alex Rakoczy <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Jun 21, 2022
@toothrot
internal/relui: improve task result formatting
bcadfe3 
Format most result types, somewhat. This implementation should be
reusable when formatting workflow outputs in the future.

For golang/go#53382

Change-Id: I4734cdefff85a37cb1047a6689411139f2ebfbc1
Reviewed-on: https://go-review.googlesource.com/c/build/+/412677
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Alex Rakoczy <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/412678 mentions this issue: internal/relui: fix log viewing errors

@toothrot toothrot self-assigned this Jun 21, 2022
gopherbot pushed a commit to golang/build that referenced this issue Jun 21, 2022
@toothrot
internal/relui: fix log viewing errors
d4b81c4 
Wait for DOMContentLoaded before trying to add listeners, as some of the
data may not be in the dom yet when many workflows are visible. If the
page has already loaded, register them immediately.

Update eslint to require function expression declarations in javascript.

Remove inline JavaScript from the workflow form. Registering event
listeners in JavaScript instead of in HTML attributes is preferable for
several reasons:

- Separation of JavaScript logic from view
- Avoids polluting the global namespace
- Allows attaching multiple listeners to elements
- Easier code re-use

Updates golang/go#53382

Change-Id: I3dfefd1212482448eb2ff23aa77f89ead57823d8
Reviewed-on: https://go-review.googlesource.com/c/build/+/412678
Run-TryBot: Alex Rakoczy <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/413581 mentions this issue: internal/relui: handle long log lines

gopherbot pushed a commit to golang/build that referenced this issue Jun 23, 2022
@toothrot
internal/relui: handle long log lines
88635cb 
Some log lines can be excessively long, breaking the page layout. This
change switches to a fixed table layout that will more gracefully handle
excessively long log lines.

For golang/go#53382

Change-Id: Ib49a086465a56c657480c52af436a5cdc06cb405
Reviewed-on: https://go-review.googlesource.com/c/build/+/413581
Run-TryBot: Alex Rakoczy <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/413582 mentions this issue: internal/relui: render more output types

gopherbot pushed a commit to golang/build that referenced this issue Jun 23, 2022
@toothrot @gopherbot
internal/relui: render more output types
3ceb9f4 
Add support for slices and numbers when rendering outputs. Stop
handling artifact slices explicitly in resultDetail in order to support
more slice types.

For golang/go#53382

Change-Id: If16f8f4240e96a1f2f756743236134f8f637b079
Reviewed-on: https://go-review.googlesource.com/c/build/+/413582
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Alex Rakoczy <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Alex Rakoczy <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/416222 mentions this issue: internal/relui: format workflow outputs

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/416221 mentions this issue: internal/relui: add build and test only workflow

gopherbot pushed a commit to golang/build that referenced this issue Jul 12, 2022
@toothrot @gopherbot
internal/relui: add build and test only workflow
75e83af 
Add a workflow for building and testing a beta release. This workflow
will not make any public-visible changes, such as publishing artifacts,
tagging, announcements, etc. It is useful for testing changes locally.

For golang/go#53382

Change-Id: Ic259aed6f0e01635055dafbdad0715de916f2352
Reviewed-on: https://go-review.googlesource.com/c/build/+/416221
Run-TryBot: Jenny Rakoczy <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Jenny Rakoczy <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Jul 12, 2022
@toothrot @gopherbot
internal/relui: format workflow outputs
de76fbe 
This change adds UI treatment for showing workflow outputs. Previously,
it was just rendered as a string. With this change, there are custom UI
elements for different output types.

For golang/go#53382

Change-Id: Ia0f875d8b3149652216ca2b82ba13a8ecd342eb7
Reviewed-on: https://go-review.googlesource.com/c/build/+/416222
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Jenny Rakoczy <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Jenny Rakoczy <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/417221 mentions this issue: internal: track starting of tasks

@dmitshur dmitshur changed the title x/build/relui: improve layout for results and outputs x/build/cmd/relui: improve layout for results and outputs Jul 13, 2022
gopherbot pushed a commit to golang/build that referenced this issue Jul 13, 2022
@toothrot
internal: track starting of tasks
876116a 
Update exported TaskState to include a "started" boolean. Record the
task started state in the database and show a different icon in the UI.

Tracking started enables several improvements. This change improves
resuming of workflows to mark tasks that started without finishing as
incomplete. This will prevent workflows resuming from an unknown state,
where a task may not be safe to resume by default, such as sending a
public announcement.

Also, this change makes minor tweaks to the UI for task ordering,
putting the most recently updated tasks at the top of the list. It also
fixes a minor but confusing bug around retrying "approval" tasks.

Updates golang/go#53382

Change-Id: Icff1c0df541a6e11a7bb0ab55beef60cd18a074a
Reviewed-on: https://go-review.googlesource.com/c/build/+/417221
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Jenny Rakoczy <[email protected]>
Auto-Submit: Jenny Rakoczy <[email protected]>
@toothrot
Copy link
Contributor Author

It's in pretty decent shape now.

@dmitshur dmitshur mentioned this issue Aug 10, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/422599 mentions this issue: internal/relui: fix layout for large parameters

gopherbot pushed a commit to golang/build that referenced this issue Aug 11, 2022
@toothrot @gopherbot
internal/relui: fix layout for large parameters
dd76e04 
Releases with a lot of security notes were difficult to read in the
interface. This change unifies params and output presentation for
workflows.

Fixes golang/go#54240
Updates golang/go#53382

Change-Id: I4602478aa245e509f305ed478898c3492bc6561b
Reviewed-on: https://go-review.googlesource.com/c/build/+/422599
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Jenny Rakoczy <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Jenny Rakoczy <[email protected]>
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@toothrot toothrot

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@toothrot @gopherbot