Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: TestTransportCancelDataResponseRace failures with "net/http: request canceled" #45701

Closed
bcmills opened this issue Apr 22, 2021 · 4 comments
Closed

x/net/http2: TestTransportCancelDataResponseRace failures with "net/http: request canceled" #45701

bcmills opened this issue Apr 22, 2021 · 4 comments
Assignees
@neild
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 22, 2021

2021-04-21T23:01:15-4e50805/freebsd-arm64-dmgk
2021-03-31T06:09:03-cb1fcc7/android-amd64-emu
2020-09-30T14:50:03-4acb6c0/freebsd-arm-paulzhol
2020-09-23T18:22:12-328152d/freebsd-arm64-dmgk
2020-09-23T18:22:12-328152d/linux-ppc64-buildlet
2019-11-25T08:49:36-ffdde10/freebsd-arm64-dmgk
2019-11-24T23:54:46-72fef5d/freebsd-arm64-dmgk
2019-11-12T18:23:07-2180aed/android-amd64-emu
2019-08-27T16:04:01-ba9fcec/solaris-amd64-oraclerel

--- FAIL: TestTransportCancelDataResponseRace (0.11s)
    transport_test.go:3323: Get "https://127.0.0.1:60106": net/http: request canceled
FAIL
FAIL	golang.org/x/net/http2	22.175s

CC @neild @empijei @bradfitz @tombergan
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 22, 2021
@bcmills bcmills added this to the Backlog milestone Apr 22, 2021
@networkimprov
Copy link

cc @fraenkel

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/320369 mentions this issue: http2: remove race from TestTransportCancelDataResponseRace

@bcmills
Copy link
Contributor Author

bcmills commented Sep 14, 2022

greplogs -l -e 'FAIL: TestTransportCancelDataResponseRace.*(?:\n.*)*net/http: request canceled' --since=2021-04-22
2022-09-06T12:35:13-83b083e-8a32354/freebsd-arm64-dmgk
2021-12-06T23:02:28-eba003a-871d63f/freebsd-arm64-dmgk
2021-04-23T18:45:38-5f58ad6-06c9756/freebsd-arm64-dmgk

@bcmills
Copy link
Contributor Author

bcmills commented Sep 14, 2022

@neild, this has a candidate fix CL awaiting review — could you take a look?

@bcmills bcmills mentioned this issue Sep 14, 2022
Closed
WeiminShang pushed a commit to WeiminShang/net that referenced this issue Nov 16, 2022
@fraenkel @neild
http2: remove race from TestTransportCancelDataResponseRace
8328fa1 
Wait for the client request to return before cancelling the request.
Then cancel the request and send more data.

Fixes: golang/go#45701

Change-Id: Icc81f9c6fefdda1d978e6234c9894f552daecd45
Reviewed-on: https://go-review.googlesource.com/c/net/+/320369
Run-TryBot: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Damien Neil <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
@golang golang locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@neild neild

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@neild @networkimprov @bcmills @gopherbot