-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/link: fail to build when using time/tzdata on ARM [1.15 backport] #44748
Labels
Milestone
Comments
Change https://golang.org/cl/298030 mentions this issue: |
cherrymui
added
the
CherryPickCandidate
Used during the release process for point releases
label
Mar 2, 2021
toothrot
added
the
CherryPickApproved
Used during the release process for point releases
label
Mar 18, 2021
Approved. This is a serious issue with no workaround. |
gopherbot
removed
the
CherryPickCandidate
Used during the release process for point releases
label
Mar 18, 2021
Closed by merging 7c88ae4 to release-branch.go1.15. |
gopherbot
pushed a commit
that referenced
this issue
Mar 25, 2021
…dent packages Currently, in the trampoline generation pass we expect packages are laid out in dependency order, so a cross-package jump always has a known target address so we can check if a trampoline is needed. With linknames, there can be cycles in the package dependency graph, making this algorithm no longer work. For them, as the target address is unkown we conservatively generate a trampoline. This may generate unnecessary trampolines (if the packages turn out laid together), but package cycles are extremely rare so this is fine. Updates #44639. Fixes #44748. Change-Id: I2dc2998edacbda27d726fc79452313a21d07787a Reviewed-on: https://go-review.googlesource.com/c/go/+/292490 Trust: Cherry Zhang <[email protected]> Reviewed-by: Than McIntosh <[email protected]> (cherry picked from commit 098504c) Reviewed-on: https://go-review.googlesource.com/c/go/+/298030 Run-TryBot: Cherry Zhang <[email protected]> TryBot-Result: Go Bot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
(Creating manually as I don't think gopherbot would do this after it already created one.)
Please consider #44639 (fixed in 098504c for Go 1.17) for backport to the next 1.15 minor release.
This causes programs fail to build without easy workaround. It applies to 1.15 as well.
The text was updated successfully, but these errors were encountered: