net: TestLookupPTR failures on windows-amd64-longtest builder #38111

bcmills · 2020-03-27T15:35:56Z

#!watchflakes
post <- builder == "windows-amd64-longtest" && pkg == "net" && test == "TestLookupPTR"

It's not obvious to me whether the test is flaky, the builder has a flaky network connection, or the test is detecting something that is actually wrong.

CC @mikioh @bradfitz @ianlancetaylor (for net), @dmitshur, @toothrot, @cagedmantis, @andybons (for builders)

2020-03-26T17:48:20-918d4d4/windows-amd64-longtest
2020-03-06T14:41:22-2b0f481/windows-amd64-longtest
2020-01-09T18:00:06-8ac98e7/windows-amd64-longtest
2019-12-30T09:34:53-4b43700/windows-amd64-longtest
2019-11-13T08:07:51-bf5f641/windows-amd64-longtest

The text was updated successfully, but these errors were encountered:

bcmills · 2020-03-27T15:37:18Z

There are at least two different failure modes:

--- FAIL: TestLookupPTR (3.92s)
    lookup_windows_test.go:167: skipping failed lookup 1.1.1.1 test: exit status 1: 
        Pinging one.one.one.one [1.1.1.1] with 32 bytes of data:
        Request timed out.
        
        Ping statistics for 1.1.1.1:
            Packets: Sent = 1, Received = 0, Lost = 1 (100% loss),
    lookup_windows_test.go:172: different results 1.1.1.1:	exp:null	got:["one.one.one.one."]
FAIL
FAIL	net	66.044s

--- FAIL: TestLookupPTR (0.07s)
    lookup_windows_test.go:160: failed 1.1.1.1: lookup 1.1.1.1: dnsquery: DNS server failure.
    lookup_windows_test.go:163: no results
    lookup_windows_test.go:172: different results 1.1.1.1:	exp:[]	got:null
FAIL
FAIL	net	57.951s

bcmills · 2021-02-19T13:56:59Z

bcmills · 2022-06-15T20:56:32Z

Still ongoing at a low rate:

greplogs -l -e 'FAIL: TestLookupPTR .*(?:\n .*)*different results 1.1.1.1:\s+exp:null\s+got:\["one\.one\.one\.one\."\]' --since=2021-02-20
2021-11-18T02:16:39-353cb71/windows-amd64-longtest
2021-04-09T09:01:07-4d7d7a4/windows-amd64-longtest
2021-03-17T17:13:50-0bd308f/windows-amd64-longtest

greplogs -l -e 'FAIL: TestLookupPTR .*(?:\n .*)*DNS server failure' --since=2021-02-20
2022-06-13T19:06:49-4703546/windows-amd64-longtest
2022-06-13T16:53:11-7eeec1f/windows-amd64-longtest

bcmills · 2022-06-27T17:45:54Z

One more this week. The mode=go line in the failure log makes me wonder whether this recent spate of failures is related to #33097, although this most recent failure is after CL 413458.

@ianlancetaylor, @bradfitz: could you double-check whether something relating to the PreferGo and netdns=go changes in 1.19 could be causing an increase in TestLookupPTR failures?

greplogs -l -e 'FAIL: TestLookupPTR .*(?:\n .*)*DNS server failure' --since=2022-06-14
2022-06-22T23:27:17-2e773a3/windows-amd64-longtest

ianlancetaylor · 2022-06-27T20:46:58Z

Note that the mode=go appears on a likely unrelated failure of TestLookupDotsWithRemoteSource. It does not appear in a failure of TestLookupPTR. It's just that both tests happened to fail in that run.

ianlancetaylor · 2022-06-27T21:09:04Z

Most of the errors are of the form

--- FAIL: TestLookupPTR (3.90s)
    lookup_windows_test.go:167: skipping failed lookup 1.1.1.1 test: exit status 1: 
        Pinging one.one.one.one [1.1.1.1] with 32 bytes of data:
        Request timed out.
        
        Ping statistics for 1.1.1.1:
            Packets: Sent = 1, Received = 0, Lost = 1 (100% loss),
    lookup_windows_test.go:172: different results 1.1.1.1:	exp:null	got:["one.one.one.one."]

The test actually runs the ping program. If the ping program fails, the test says skipping failed lookup. But it doesn't actually skip the test. All of those errors are flakes.

There are also some errors in which the DnsQuery Windows function fails with DNS_ERROR_RCODE_SERVER_FAILURE. The documentation for that error is "DNS server failure." I don't know what is going on there. As far as I can tell the code that is failing is unchanged since 1.18. This case only happens when using netdns=cgo, the default in 1.18 and earlier on Windows.

gopherbot · 2022-06-27T21:11:31Z

Change https://go.dev/cl/414634 mentions this issue: net: really skip Windows TestLookupPTR test if we say we are skipping it

For #38111 Change-Id: I2651687367af68ee070ea91106f4bc18adab2762 Reviewed-on: https://go-review.googlesource.com/c/go/+/414634 Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

For golang#38111 Change-Id: I2651687367af68ee070ea91106f4bc18adab2762 Reviewed-on: https://go-review.googlesource.com/c/go/+/414634 Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

bcmills · 2022-09-02T15:21:55Z

https://storage.googleapis.com/go-build-log/a47db80f/windows-amd64-longtest_2ecbeb5f.log:

--- FAIL: TestLookupPTR (0.08s)
    lookup_windows_test.go:174: failed 1.1.1.1: lookup 1.1.1.1: dnsquery: DNS server failure.
    lookup_windows_test.go:177: no results
    lookup_windows_test.go:187: different results 1.1.1.1:	exp:[]	got:null
FAIL
FAIL	net	47.405s

bcmills · 2022-09-02T15:26:02Z

greplogs -l -e 'FAIL: TestLookupPTR .*(?:\n .*)*DNS server failure' --since=2022-06-16
2022-09-02T02:09:03-a31c062/windows-amd64-longtest
2022-08-31T16:59:38-0d6a7f9/windows-amd64-longtest
2022-08-31T15:30:57-d01200e/windows-amd64-longtest
2022-08-17T16:26:24-014f0e8/windows-amd64-longtest
2022-08-12T01:52:46-09cc9ba/windows-amd64-longtest
2022-08-08T14:11:19-6e9925c/windows-amd64-longtest
2022-07-29T22:09:32-9a2001a/windows-amd64-longtest
2022-06-22T23:27:17-2e773a3/windows-amd64-longtest

bcmills · 2022-09-02T15:38:22Z

(CC @golang/windows)

gopherbot · 2022-09-02T15:39:28Z

Change https://go.dev/cl/427915 mentions this issue: net: skip TestLookupPTR when LookupAddr fails with "DNS server failure"

For #38111. Change-Id: I43bdd756bde0adcd156cf9750b49b3b989304df7 Reviewed-on: https://go-review.googlesource.com/c/go/+/427915 Reviewed-by: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]>

mknyszek · 2022-09-06T21:22:13Z

Another recent flake:

2022-09-02T02:09:03-a31c062/windows-amd64-longtest

gopherbot · 2022-09-21T19:00:37Z

Found new dashboard test flakes for:

#!watchflakes
post <- builder == "windows-amd64-longtest" && pkg == "net" && test == "TestLookupPTR"

2022-07-29 22:09 windows-amd64-longtest go@9a2001a8 net.TestLookupPTR (log)

--- FAIL: TestLookupPTR (0.10s)
    lookup_windows_test.go:174: failed 1.1.1.1: lookup 1.1.1.1: dnsquery: DNS server failure.
    lookup_windows_test.go:177: no results
    lookup_windows_test.go:187: different results 1.1.1.1:	exp:[]	got:null

2022-08-17 16:26 windows-amd64-longtest go@014f0e82 net.TestLookupPTR (log)

--- FAIL: TestLookupPTR (0.09s)
    lookup_windows_test.go:174: failed 1.1.1.1: lookup 1.1.1.1: dnsquery: DNS server failure.
    lookup_windows_test.go:177: no results
    lookup_windows_test.go:187: different results 1.1.1.1:	exp:[]	got:null

2022-08-26 18:28 windows-amd64-longtest go@bf812b32 net.TestLookupPTR (log)

--- FAIL: TestLookupPTR (0.08s)
    lookup_windows_test.go:160: failed 1.1.1.1: lookup 1.1.1.1: dnsquery: DNS server failure.
    lookup_windows_test.go:163: no results
    lookup_windows_test.go:172: different results 1.1.1.1:	exp:[]	got:null

2022-08-31 15:30 windows-amd64-longtest go@d01200e7 net.TestLookupPTR (log)

--- FAIL: TestLookupPTR (0.09s)
    lookup_windows_test.go:174: failed 1.1.1.1: lookup 1.1.1.1: dnsquery: DNS server failure.
    lookup_windows_test.go:177: no results
    lookup_windows_test.go:187: different results 1.1.1.1:	exp:[]	got:null

2022-08-31 16:59 windows-amd64-longtest go@0d6a7f9d net.TestLookupPTR (log)

--- FAIL: TestLookupPTR (0.18s)
    lookup_windows_test.go:174: failed 1.1.1.1: lookup 1.1.1.1: dnsquery: DNS server failure.
    lookup_windows_test.go:177: no results
    lookup_windows_test.go:187: different results 1.1.1.1:	exp:[]	got:null

2022-09-02 02:09 windows-amd64-longtest go@a31c062c net.TestLookupPTR (log)

--- FAIL: TestLookupPTR (0.06s)
    lookup_windows_test.go:174: failed 8.8.8.8: lookup 8.8.8.8: dnsquery: DNS server failure.
    lookup_windows_test.go:177: no results
    lookup_windows_test.go:187: different results 8.8.8.8:	exp:[]	got:null

— watchflakes

bcmills · 2023-02-15T22:28:15Z

This may be fixed by CL 462051.

gopherbot · 2023-03-15T22:28:49Z

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

bcmills added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows labels Mar 27, 2020

bcmills added this to the Backlog milestone Mar 27, 2020

bcmills mentioned this issue Jun 27, 2022

net: make Resolver.PreferGo and GODEBUG=netdns=go use Go code on Windows #33097

Closed

dmitshur mentioned this issue Aug 5, 2022

build dashboard triage log #52653

Closed

rsc added this to Proposals and Test Flakes Sep 21, 2022

rsc removed this from Proposals Sep 21, 2022

rsc moved this to Active in Test Flakes Sep 21, 2022

bcmills mentioned this issue Sep 28, 2022

all: test failures due to windows dns errors #55165

Open

bcmills mentioned this issue Nov 9, 2022

net: Resolver errors on Windows with code WSATRY_AGAIN #55050

Closed

bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Feb 15, 2023

gopherbot closed this as completed Mar 15, 2023

github-project-automation bot moved this from Active to Done in Test Flakes Mar 15, 2023

golang locked and limited conversation to collaborators Mar 14, 2024

gopherbot added the FrozenDueToAge label Mar 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: TestLookupPTR failures on windows-amd64-longtest builder #38111

net: TestLookupPTR failures on windows-amd64-longtest builder #38111

bcmills commented Mar 27, 2020 •

edited by rsc

Loading

bcmills commented Mar 27, 2020

bcmills commented Feb 19, 2021

bcmills commented Jun 15, 2022

bcmills commented Jun 27, 2022

ianlancetaylor commented Jun 27, 2022

ianlancetaylor commented Jun 27, 2022

gopherbot commented Jun 27, 2022

bcmills commented Sep 2, 2022

bcmills commented Sep 2, 2022

bcmills commented Sep 2, 2022

gopherbot commented Sep 2, 2022

mknyszek commented Sep 6, 2022

gopherbot commented Sep 21, 2022

bcmills commented Feb 15, 2023

gopherbot commented Mar 15, 2023

net: TestLookupPTR failures on windows-amd64-longtest builder #38111

net: TestLookupPTR failures on windows-amd64-longtest builder #38111

Comments

bcmills commented Mar 27, 2020 • edited by rsc Loading

bcmills commented Mar 27, 2020

bcmills commented Feb 19, 2021

bcmills commented Jun 15, 2022

bcmills commented Jun 27, 2022

ianlancetaylor commented Jun 27, 2022

ianlancetaylor commented Jun 27, 2022

gopherbot commented Jun 27, 2022

bcmills commented Sep 2, 2022

bcmills commented Sep 2, 2022

bcmills commented Sep 2, 2022

gopherbot commented Sep 2, 2022

mknyszek commented Sep 6, 2022

gopherbot commented Sep 21, 2022

bcmills commented Feb 15, 2023

gopherbot commented Mar 15, 2023

bcmills commented Mar 27, 2020 •

edited by rsc

Loading