Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerRegisterSuspendResumeNotification error on Azure App Services with go 1.13.7 [1.14 backport] #37699

Closed
dmitshur opened this issue Mar 5, 2020 · 3 comments
Closed

PowerRegisterSuspendResumeNotification error on Azure App Services with go 1.13.7 [1.14 backport] #37699

dmitshur opened this issue Mar 5, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.2

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Mar 5, 2020

@networkimprov requested issue #37149 to be considered for backport to the next 1.14 minor release.

@gopherbot ple​ase backport. It's another instance of this regression...
@dmitshur dmitshur added the CherryPickCandidate Used during the release process for point releases label Mar 5, 2020
@dmitshur dmitshur added this to the Go1.14.1 milestone Mar 5, 2020
@gopherbot gopherbot mentioned this issue Mar 5, 2020
Closed
@douglaswth douglaswth mentioned this issue Mar 17, 2020
Open
@cagedmantis cagedmantis modified the milestones: Go1.14.1, Go1.14.2 Mar 19, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/224586 mentions this issue: [release-branch.go1.14] runtime: ignore error returned by PowerRegisterSuspendResumeNotification

@ianlancetaylor
Copy link
Member

Any Go program fails to start in certain restricted environments when running Windows. Cherry pick approved.

@ianlancetaylor ianlancetaylor added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 25, 2020
gopherbot pushed a commit that referenced this issue Mar 25, 2020
@alexbrainman @ianlancetaylor
[release-branch.go1.14] runtime: ignore error returned by PowerRegist…
7487066 
…erSuspendResumeNotification

It appears that PowerRegisterSuspendResumeNotification is not supported
when running inside Docker - see issues #35447, #36557 and #37149.

Our current code relies on error number to determine Docker environment.
But we already saw PowerRegisterSuspendResumeNotification return
ERROR_FILE_NOT_FOUND, ERROR_INVALID_PARAMETERS and ERROR_ACCESS_DENIED
(see issues above). So this approach is not sustainable.

Just ignore PowerRegisterSuspendResumeNotification returned error.

For #37149
Fixes #37699

Change-Id: I2beba9d45cdb8c1efac5e974e747827a6261915a
Reviewed-on: https://go-review.googlesource.com/c/go/+/219657
Run-TryBot: Alex Brainman <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Austin Clements <[email protected]>
Reviewed-by: Jason A. Donenfeld <[email protected]>
(cherry picked from commit d467f3b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/224586
Run-TryBot: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

Closed by merging 7487066 to release-branch.go1.14.

@golang golang locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.2
Development

No branches or pull requests
4 participants
@cagedmantis @dmitshur @ianlancetaylor @gopherbot