Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestServerConnState is flaky on darwin-arm64-corellium builder #37322

Closed
bcmills opened this issue Feb 20, 2020 · 5 comments
Closed

net/http: TestServerConnState is flaky on darwin-arm64-corellium builder #37322

bcmills opened this issue Feb 20, 2020 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 20, 2020

Issue #32329 was addressed in December. Since that time, TestServerConnState has continued to flake, but only on the darwin-arm64-corellium builder.

I'm not sure whether this is a bug in the builder, or a general bug that this builder just happens to trigger (for example, due to unusual performance characteristics).

2020-02-19T22:04:41-3457359/darwin-arm64-corellium
2020-02-07T16:49:14-1a37095/darwin-arm64-corellium
2020-01-31T05:52:03-862a57d/darwin-arm64-corellium
2020-01-29T14:58:15-1319bb9/darwin-arm64-corellium

--- FAIL: TestServerConnState (5.06s)
    serve_test.go:4227: Timed out waiting for connection to change state.
    serve_test.go:4227: Request(s) produced unexpected state sequence.
        Got:  [new]
        Want: [new closed]
    serve_test.go:4172: unexpected conn in state closed
FAIL
FAIL	net/http	10.571s
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 20, 2020
@bcmills bcmills added this to the Backlog milestone Feb 20, 2020
@bcmills bcmills added the Builders x/build issues (builders, bots, dashboards) label Feb 20, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Feb 20, 2020

Is it possible that this builder is just so slow that a 5-second timeout is insufficient? Perhaps we should raise the timeout and see if it persists.

@bcmills
Copy link
Contributor Author

bcmills commented Mar 11, 2020

2020-03-06T23:33:17-b00ebea/darwin-arm64-corellium
2020-02-19T22:04:41-3457359/darwin-arm64-corellium
2020-02-07T16:49:14-1a37095/darwin-arm64-corellium
2020-01-31T05:52:03-862a57d/darwin-arm64-corellium

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/222957 mentions this issue: net/http: use t.Deadline instead of an arbitrary timeout in TestServerConnState

@bcmills
Copy link
Contributor Author

bcmills commented Mar 11, 2020

CC @znly

@bcmills bcmills mentioned this issue Mar 11, 2020
Closed
gopherbot pushed a commit that referenced this issue Mar 11, 2020
net/http: use t.Deadline instead of an arbitrary timeout in TestServe…
0e3ace4 
…rConnState

Updates #37322

Change-Id: I3b8369cd9e0ed5e4b3136cedaa2f70698ead2270
Reviewed-on: https://go-review.googlesource.com/c/go/+/222957
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
@bcmills bcmills mentioned this issue Mar 16, 2020
Closed
@bcmills
Copy link
Contributor Author

bcmills commented Jan 20, 2022

No recent failures on any kind of darwin:

greplogs --dashboard -md -l -e 'FAIL: TestServerConnState' --since=2021-01-01

2022-01-19T20:54:49-1efc581/plan9-arm
2021-11-17T19:50:58-88474d4/openbsd-386-68

@bcmills bcmills closed this as completed Jan 20, 2022
@golang golang locked and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot