x/crypto/ssh/terminal: ReadPassword() ignores Return-Key

[johmue]

What version of Go are you using (go version)?

$ go version
go version go1.13.6 windows/amd64

Does this issue reproduce with the latest release?

no (see comment on latest commit)

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\username\AppData\Local\go-build
set GOENV=C:\Users\username\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\username\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=c:\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\Username~1\AppData\Local\Temp\go-build859645086=/tmp/go-build -gno-record-gcc-switches

What did you do?

package main

import (
    "log"
    "syscall"
    "golang.org/x/crypto/ssh/terminal"
)

func main() {
	log.Print("Your user password: ")
	bytePassword, err := terminal.ReadPassword(int(syscall.Stdin))
	if err != nil {
		log.Fatalf("unable to read password from cli")
	}
	password := string(bytePassword)
	log.Print(password)
}

What did you expect to see?

If you run it and write hello and press return key it should log hello

What did you see instead?

program ignores return key and will not continue to the next step

Note

Please see my comment on commit golang/crypto@6d4e4cb

[toothrot]

/cc @mattn @alexbrainman @hanwen @FiloSottile and #36071

[gopherbot]

Change https://golang.org/cl/215417 mentions this issue: ssh/terminal: adjust ReadConsole rules on windows

[alexbrainman]

@johmue thank you for filling this issue.

This https://golang.org/cl/215417 should fix your problem. Can you try it, please?

Thank you.

Alex

[johmue]

@alexbrainman I tried with Windows 10 and it seems to work fine now. Thx for taking care of it.