Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytes/hash: TestSmhasherSeed flaky on 32-bit builders #33988

Closed
bcmills opened this issue Aug 30, 2019 · 4 comments
Closed

bytes/hash: TestSmhasherSeed flaky on 32-bit builders #33988

bcmills opened this issue Aug 30, 2019 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 30, 2019

Seen on the windows-386-2008 builder, likely as a result of CL 186877 (#28322):

https://build.golang.org/log/2be333e9f2c0cdac67f47107a5a7a8411982f8fd

--- FAIL: TestSmhasherSeed (0.09s)
    smhasher_test.go:94: unexpected number of collisions: got=11 mean=0.000000 stddev=0.000033
FAIL
FAIL	bytes/hash	0.254s
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Aug 30, 2019
@bcmills bcmills added this to the Go1.14 milestone Aug 30, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Aug 30, 2019

linux-386-387: https://build.golang.org/log/f371d2f41f07168250f1a4f6da413a722a2bbe5f

@bcmills bcmills changed the title bytes/hash: TestSmhasherSeed failure on windows-386-2008 builder bytes/hash: TestSmhasherSeed flaky on 32-bit builders Aug 30, 2019
@ALTree
Copy link
Member

ALTree commented Sep 3, 2019

darwin-386-10_14: https://build.golang.org/log/c3df795bd63e01fb9e9f9b804e80edcced255004

@bcmills bcmills added the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Sep 3, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Sep 3, 2019

freebsd-386-12_0:

@randall77, if there isn't an easy fix please add a Skip for the test on 32-bit targets in the meantime.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/193078 mentions this issue: bytes/hash: disable seed test on 32-bit platforms

t4n6a1ka pushed a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
@randall77 @t4n6a1ka
bytes/hash: disable seed test on 32-bit platforms
463fe1d 
The distribution of hash outputs when varying the seed is
not good enough on 32-bit platforms.

This isn't a likely attack vector (the adversary controlling the seed),
so it isn't a huge deal. Would be nice to fix, though. For now, just
skip this test.

Fixes golang#33988

Change-Id: Icf51ab687fc215422a5492ae78e6f414b33e04cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/193078
Run-TryBot: Keith Randall <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
@golang golang locked and limited conversation to collaborators Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
4 participants
@ALTree @bcmills @randall77 @gopherbot