Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_test fails because of ??? filename #33

Closed
gopherbot opened this issue Nov 11, 2009 · 6 comments
Closed

log_test fails because of ??? filename #33

gopherbot opened this issue Nov 11, 2009 · 6 comments

Comments

@gopherbot
Copy link
Contributor

by julians37:

What steps will reproduce the problem?
1. ./all.bash

What is the expected output? What do you see instead?

TestAllLog fails

What is your $GOOS?  $GOARCH?

linux_amd64

Which revision are you sync'ed to?  (hg log -l 1)

changeset:   3975:b51fd2d6c160
tag:         tip
user:        Kevin Ballard <[email protected]>
date:        Tue Nov 10 20:05:24 2009 -0800
summary:     Implement new emacs command M-x gofmt

Please provide any additional information below.

log.go's formatHeader seems to have trouble getting the stack frame. The 
same test passes no problem on an i686 machine.

make[2]: Leaving directory `/redacted/src/pkg/log'
--- FAIL: log.TestAllLog
        log output should match "^/[A-Za-z0-9_/\\-.]+\\.go:[0-9]+: hello 
23 world$" is "/???/log_test.go:60: hello 23 world"
        log output should match "^/[A-Za-z0-9_/\\-.]+\\.go:[0-9]+: hello 
23 world$" is "/???/log_test.go:58: hello 23 world"
        log output should match "^XXX[0-9][0-9][0-9][0-9]/[0-9][0-9]/[0-
9][0-9] [0-9][0-9]:[0-9][0-9]:[0-9][0-9]\\.[0-9][0-9][0-9][0-9][0-9][0-
9] /[A-Za-z0-9_/\\-.]+\\.go:[0-9]+: hello 23 world$" is "XXX2009/1
1/11 20:36:28.877982 /???/log_test.go:60: hello 23 world"
        log output should match "^XXX[0-9][0-9][0-9][0-9]/[0-9][0-9]/[0-
9][0-9] [0-9][0-9]:[0-9][0-9]:[0-9][0-9]\\.[0-9][0-9][0-9][0-9][0-9][0-
9] /[A-Za-z0-9_/\\-.]+\\.go:[0-9]+: hello 23 world$" is "XXX2009/1
1/11 20:36:28.878142 /???/log_test.go:58: hello 23 world"
FAIL
make[1]: *** [test] Error 1
make[1]: Leaving directory `/redacted/src/pkg/log'
make: *** [log.test] Error 2

$ uname -a
Linux heta 2.6.20.5_rsp_3.9 #1 SMP Wed Oct 14 16:24:34 EST 2009 
x86_64 x86_64 x86_64 GNU/Linux

$ gcc --version
gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-44)
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR 
PURPOSE.

$ cat /etc/redhat-release 
CentOS release 5.3 (Final)
@gopherbot
Copy link
Contributor Author

Comment 1 by qwertymaniac:

Same as issue #27..

@gopherbot
Copy link
Contributor Author

Comment 2 by julians37:

No, issue #27 is because the path contains a dot and the regular expression doesn't 
match dots in filenames. This issue is about the path not being determined and reported 
as ???.

@gopherbot
Copy link
Contributor Author

Comment 3 by qwertymaniac:

Ah I see, thank you for pointing that :)

@rsc
Copy link
Contributor

rsc commented Nov 11, 2009

Comment 4:

Status changed to Duplicate.

Merged into issue #31.

@gopherbot
Copy link
Contributor Author

Comment 5:

CL https://golang.org/cl/125940043 mentions this issue.

minux pushed a commit to minux/goios that referenced this issue Feb 27, 2015
Basically revert d72d223. d72d223 was wrong. The size of a symbol is
correctly calculated before generating the machine code image. The fault
described in d72d223 was due to the problem fixed in b6e15ed.

Fixes golang#33
@gopherbot
Copy link
Contributor Author

CL https://golang.org/cl/10115 mentions this issue.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants