-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: replace directives are not thoroughly documented #32058
Comments
Hello @heschik Can I pick up this task |
@jayconrod or @bcmills would be the ones to review it, and they might be pretty busy getting 1.13 ready, so there might be a bit of delay on the review. For my part I say go for it. |
A CL to document the existing behavior would be fine, but note that for Go 1.14 we're planning to both revamp the semantics of |
Change https://golang.org/cl/220080 mentions this issue: |
Updates golang/go#36460 Updates golang/go#27900 Updates golang/go#26955 Updates golang/go#30831 Updates golang/go#32058 Updates golang/go#32380 Updates golang/go#32419 Updates golang/go#33370 Updates golang/go#33669 Updates golang/go#36369 Change-Id: I1d4644e3e8b4e688c2fc5a569312495e5072b7d7 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/220080 Reviewed-by: Russ Cox <[email protected]>
We should also note that |
I guess we can close this now the cmd/go just links to https://go.dev/ref/mod for documentation, which has a dedicated replace section https://go.dev/ref/mod#go-mod-file-replace |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What did you do?
Read
go help modules
andgo help go.mod
.What did you expect to see?
Some discussion of what replacements are and what they do.
What did you see instead?
The only documentation I can find is these lines in
go help go.mod
:I think there's probably more to say about how replace works. For example, it doesn't explicitly state that the thing to replace is on the left side of the arrow. It also doesn't mention that the version on the left is optional.
The text was updated successfully, but these errors were encountered: