Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc/cgo/test: issue24161 tests broken on Darwin #29175

Closed
bcmills opened this issue Dec 11, 2018 · 4 comments
Closed

misc/cgo/test: issue24161 tests broken on Darwin #29175

bcmills opened this issue Dec 11, 2018 · 4 comments
Labels
FrozenDueToAge OS-Darwin release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.12

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 11, 2018 •
edited
Loading

CL 152762 (which fixes #27340) appears to have broken the misc/cgo/test regression tests for #24161 on the darwin builders.

Sample log: https://build.golang.org/log/ace9419991890f522f2affbe8f1ceb2e6d5fe9fa

##### ../misc/cgo/test
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161res
issue24161res/restype.go:20:81: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e1
issue24161e1/main.go:29:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e1/main.go:29:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
issue24161e1/main.go:33:132: invalid operation: desc != 0 (mismatched types _Ctype_CFStringRef and int)
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e2
issue24161e2/main.go:31:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e2/main.go:31:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161arg
issue24161arg/def.go:16:65: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
issue24161arg/use.go:18:58: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e0
issue24161e0/main.go:26:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e0/main.go:26:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
FAIL	_/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test [build failed]
2018/12/10 20:18:09 Failed: exit status 2
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161res
issue24161res/restype.go:20:81: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161arg
issue24161arg/def.go:16:65: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
issue24161arg/use.go:18:58: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e1
issue24161e1/main.go:29:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e1/main.go:29:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
issue24161e1/main.go:33:132: invalid operation: desc != 0 (mismatched types _Ctype_CFStringRef and int)
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e2
issue24161e2/main.go:31:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e2/main.go:31:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e0
issue24161e0/main.go:26:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e0/main.go:26:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
FAIL	_/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test [build failed]
2018/12/10 20:18:10 Failed: exit status 2
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161res
issue24161res/restype.go:20:81: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161arg
issue24161arg/def.go:16:65: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
issue24161arg/use.go:18:58: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e2
issue24161e2/main.go:31:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e2/main.go:31:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e1
issue24161e1/main.go:29:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e1/main.go:29:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
issue24161e1/main.go:33:132: invalid operation: desc != 0 (mismatched types _Ctype_CFStringRef and int)
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e0
issue24161e0/main.go:26:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e0/main.go:26:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
FAIL	_/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test [build failed]
2018/12/10 20:18:11 Failed: exit status 2
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161res
issue24161res/restype.go:20:81: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e1
issue24161e1/main.go:29:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e1/main.go:29:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
issue24161e1/main.go:33:132: invalid operation: desc != 0 (mismatched types _Ctype_CFStringRef and int)
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e2
issue24161e2/main.go:31:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e2/main.go:31:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161e0
issue24161e0/main.go:26:52: cannot convert 0 (type int) to type _Ctype_SecKeyRef
issue24161e0/main.go:26:147: cannot convert 0 (type int) to type _Ctype_CFDataRef
# _/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test/issue24161arg
issue24161arg/def.go:16:65: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
issue24161arg/use.go:18:58: cannot convert 0 (type int) to type _Ctype_CFAllocatorRef
FAIL	_/private/var/folders/6g/8k13h11n2zb8hxx99wk6f6y40000gn/T/workdir/go/misc/cgo/test [build failed]
2018/12/10 20:18:11 Failed: exit status 2
2018/12/10 20:18:12 FAILED

CC @eliasnaur @ianlancetaylor @randall77
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. OS-Darwin release-blocker labels Dec 11, 2018
@bcmills bcmills added this to the Go1.12 milestone Dec 11, 2018
@bcmills bcmills changed the title misc/cgo/test: issue24161res broken on Darwin misc/cgo/test: issue24161 tests broken on Darwin Dec 11, 2018
@ianlancetaylor ianlancetaylor self-assigned this Dec 11, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/153597 mentions this issue: cmd/cgo: don't cache bad pointer typedefs

@FiloSottile
Copy link
Contributor

@gopherbot please open a backport issue for 1.11, as CL 152762 was cherry-picked there, causing the same issue.

@gopherbot gopherbot mentioned this issue Dec 14, 2018
Closed
@gopherbot
Copy link
Contributor

Backport issue(s) opened: #29272 (for 1.11).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/154299 mentions this issue: [release-branch.go1.11] cmd/cgo: don't cache bad pointer typedefs

gopherbot pushed a commit that referenced this issue Dec 14, 2018
@ianlancetaylor @FiloSottile
[release-branch.go1.11] cmd/cgo: don't cache bad pointer typedefs
17bf5e9 
The set of bad pointer typedefs changes as we see more typedefs, so
avoid looking in the cache when we find one.

Updates #29175
Fixes #29272

Change-Id: Idd82289bdd8628d11a983fa5ec96517e3a5bcbf1
Reviewed-on: https://go-review.googlesource.com/c/153597
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
(cherry picked from commit 01e072d)
Reviewed-on: https://go-review.googlesource.com/c/154299
Run-TryBot: Filippo Valsorda <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
@golang golang locked and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Darwin release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@FiloSottile @ianlancetaylor @bcmills @gopherbot