Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8c -a proc.c aborts in runtime #29

Closed
gopherbot opened this issue Nov 11, 2009 · 3 comments
Closed

8c -a proc.c aborts in runtime #29

gopherbot opened this issue Nov 11, 2009 · 3 comments
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link
Contributor

by cdsund:

What steps will reproduce the problem?
1. ./all.bash

What is the expected output? What do you see instead?
No errors expected.

%%%% making pkg %%%%

cd runtime && make install
cd unicode && make install
cd sort && make install
cd math && make install
make[1]: Entering directory `/home/chad/go/src/pkg/runtime'
8g -o _go_.8 extern.go type.go
make[1]: Entering directory `/home/chad/go/src/pkg/unicode'
8g -o _go_.8 digit.go letter.go tables.go
make[1]: Entering directory `/home/chad/go/src/pkg/sort'
8g -o _go_.8 sort.go
8c -a proc.c >runtime.acid.386
/bin/sh: line 1: 28954 Aborted                 8c -a proc.c > runtime.acid.386
make[1]: *** [runtime.acid.386] Error 134
make[1]: Leaving directory `/home/chad/go/src/pkg/runtime'
make: *** [runtime.install] Error 2
make: *** Waiting for unfinished jobs....
make[1]: Entering directory `/home/chad/go/src/pkg/math'
8g -o _go_.8 asin.go atan.go atan2.go bits.go const.go exp.go fabs.go
floor.go fmod.go hypot.go log.go pow.go pow10.go sin.go sinh.go sqrt.go
tan.go tanh.go unsafe.go
rm -f _obj/sort.a
gopack grc _obj/sort.a _go_.8
cp _obj/sort.a /home/chad/go/pkg/linux_386/sort.a
make[1]: Leaving directory `/home/chad/go/src/pkg/sort'
rm -f _obj/math.a
gopack grc _obj/math.a _go_.8
cp _obj/math.a /home/chad/go/pkg/linux_386/math.a
make[1]: Leaving directory `/home/chad/go/src/pkg/math'
rm -f _obj/unicode.a
gopack grc _obj/unicode.a _go_.8
cp _obj/unicode.a /home/chad/go/pkg/linux_386/unicode.a
make[1]: Leaving directory `/home/chad/go/src/pkg/unicode'
[chad@localhost src]$

What is your $GOOS?  $GOARCH?
GOOS=linux, GOARCH=386

Which revision are you sync'ed to?  (hg log -l 1)
3977:a522a4541e0e

Please provide any additional information below.
pclinuxos: kernel 2.6.26.8.tex3
@rsc
Copy link
Contributor

rsc commented Nov 11, 2009

Comment 2:

Status changed to Started.

@rsc
Copy link
Contributor

rsc commented Nov 11, 2009

Comment 3:

This issue was closed by revision ae39a1d.

Status changed to Fixed.

Merged into issue #-.

@tylerarnold tylerarnold mentioned this issue Feb 6, 2015
Closed
@gopherbot
Copy link
Contributor Author

CL https://golang.org/cl/10554 mentions this issue.

aclements added a commit that referenced this issue Jun 2, 2015
@aclements
runtime: increase precision of gctrace times
cc6a7fc 
Currently we truncate gctrace clock and CPU times to millisecond
precision. As a result, many phases are typically printed as 0, which
is fine for user consumption, but makes gathering statistics and
reports over GC traces difficult.

In 1.4, the gctrace line printed times in microseconds. This was
better for statistics, but not as easy for users to read or interpret,
and it generally made the trace lines longer.

This change strikes a balance between these extremes by printing
milliseconds, but including the decimal part to two significant
figures down to microsecond precision. This remains easy to read and
interpret, but includes more precision when it's useful.

For example, where the code currently prints,

gc #29 @1.629s 0%: 0+2+0+12+0 ms clock, 0+2+0+0/12/0+0 ms cpu, 4->4->2 MB, 4 MB goal, 1 P

this prints,

gc #29 @1.629s 0%: 0.005+2.1+0+12+0.29 ms clock, 0.005+2.1+0+0/12/0+0.29 ms cpu, 4->4->2 MB, 4 MB goal, 1 P

Fixes #10970.

Change-Id: I249624779433927cd8b0947b986df9060c289075
Reviewed-on: https://go-review.googlesource.com/10554
Reviewed-by: Russ Cox <[email protected]>
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsc @gopherbot