Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/ssh: revive tests, run by default on trybots #25386

Closed
bradfitz opened this issue May 14, 2018 · 5 comments
Closed

x/crypto/ssh: revive tests, run by default on trybots #25386

bradfitz opened this issue May 14, 2018 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

The x/crypto/ssh integration tests with OpenSSH's sshd in x/crypto/ssh/test don't run by default, and don't seem to work on Debian Jessie nor Debian Stretch.

It's not clear when they last worked or in which environment.

This is a tracking bug to revive them and make them run on the builders.

/cc @hanwen
@bradfitz bradfitz self-assigned this May 14, 2018
@gopherbot gopherbot added this to the Unreleased milestone May 14, 2018
@bradfitz bradfitz added the Testing An issue that has been verified to require only test changes, not just a test failure. label May 14, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/113059 mentions this issue: dashboard, env: add Debian Stretch builder, rename Jessie builder

@bradfitz
Copy link
Contributor Author

This will need a Debian Stretch builder, as Debian Jessie (our current builders) have OpenSSH 6.6 and it wasn't until OpenSSH 6.7 that forwarding Unix sockets was supported, which the x/crypto/ssh tests try to exercise. Also, OpenSSH 6.6 doesn't recognize the sshd_config option PubkeyAcceptedKeyTypes.

gopherbot pushed a commit to golang/build that referenced this issue May 14, 2018
@bradfitz
dashboard, env: add Debian Stretch builder, rename Jessie builder
ade2862 
Updates golang/go#25386

Change-Id: I65e3dda63e5ea86fa94480e3305556b73afe121a
Reviewed-on: https://go-review.googlesource.com/113059
Reviewed-by: Bryan C. Mills <[email protected]>
@bradfitz bradfitz removed their assignment Nov 1, 2018
@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Nov 1, 2018
@bradfitz
Copy link
Contributor Author

bradfitz commented Nov 1, 2018

/cc @dmitshur @katiehockman

@bradfitz
Copy link
Contributor Author

bradfitz commented Apr 2, 2019

This now works, once we updated linux-amd64 to stretch in https://go-review.googlesource.com/c/build/+/170282

Tested with gomote.

@bradfitz bradfitz closed this as completed Apr 2, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/170397 mentions this issue: cmd/gomote: add -firewall flag to run, defaulting to off

gopherbot pushed a commit to golang/build that referenced this issue Apr 2, 2019
@bradfitz
cmd/gomote: add -firewall flag to run, defaulting to off
49a6a61 
While debugging golang/go#25386 I found that the firewall defaulting
to on made debugging modules hard. So make gomote default to
no outbound firewall and make it opt-in for people who
want to reproduce the builder more.

Also in this CL: start to use server's builder config, not local state
(follow up to CL 169678 which was incomplete). It's still incomplete
in this CL, but there's now a panic with more useful information to
users telling them to update their binary.

Updates golang/go#30929

Change-Id: I17bded71919af1e7a9181866a1349eb72da40051
Reviewed-on: https://go-review.googlesource.com/c/build/+/170397
Reviewed-by: Dmitri Shuralyov <[email protected]>
@golang golang locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot