runtime: signal handling: cgoSigtramp fails to save C callee-save registers.

[bcmills]

In programs using cgo, runtime.setsig registers runtime.cgoSigtramp as the handler for signals to the runtime. cgoSigtramp calls sigtramp, which calls sigtrampgo, which uses the Go calling convention. The Go convention treats all registers except the stack pointer and frame pointer as caller-save (#16922).

In debugging #17641, I noticed that cgoSigtramp does not save the C callee-save registers before invoking those Go functions. If the call to the Go handler is forwarded through other C handlers (as in the case of TSAN interceptors; see #18255), that potentially results in corruption of the register contents and undefined behavior when control returns to the C caller.

I am attempting to write a reproducible test-case and will post it here as an update.

[bcmills]

The repro case is a minor variation on the test-case added in change 34239, obtained by making a local variable live across the invocation of the deferred handler:

$ diff -u $GOROOT/misc/cgo/testsanitizers/tsan9.go ./issue18328.go
--- /home/bcmills/src/go/misc/cgo/testsanitizers/tsan9.go      2016-12-15 11:54:46.895601246 -0800
+++ ./issue18328.go     2016-12-15 12:40:58.691484523 -0800
@@ -19,10 +19,14 @@
        size_t n;
        struct timeval tvstart, tvnow;
        int diff;
+       void *prev = NULL, *cur;

        gettimeofday(&tvstart, NULL);
        for (n = 0; n < 1<<20; n++) {
-               free(malloc(n));
+               cur = malloc(n);
+               free(prev);
+               prev = cur;
+
                gettimeofday(&tvnow, NULL);
                diff = (tvnow.tv_sec - tvstart.tv_sec) * 1000 * 1000 + (tvnow.tv_usec - tvstart.tv_usec);

@@ -32,6 +36,8 @@
                        break;
                }
        }
+
+       free(prev);
 }
 */
 import "C"

$ go version
go version devel +94e0f06 Thu Dec 15 18:17:32 2016 +0000 linux/amd64

$ $(go env CC) --version
clang version 3.8.0-2ubuntu3~trusty4 (tags/RELEASE_380/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

$ go build issue18328 && ./issue18328
Segmentation fault (core dumped)

[bcmills]

@ianlancetaylor: I'm guessing one of us should fix this. I'm happy to send a patch unless you want to do it yourself.

[gopherbot]

CL https://golang.org/cl/34501 mentions this issue.

[gopherbot]

CL https://golang.org/cl/35068 mentions this issue.