Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile: needs to build standard library as PIC for android #12581

Closed
mwhudson opened this issue Sep 11, 2015 · 2 comments
Closed

x/mobile: needs to build standard library as PIC for android #12581

mwhudson opened this issue Sep 11, 2015 · 2 comments
Labels
FrozenDueToAge

Comments

@mwhudson
Copy link
Contributor

gomobile installs the standard library for you but it just compiles it with the default flags. Thanks to the use of -pkgdir, the attempts made by the go tool to build the runtime as PIC when -buildmode=c-shared is passed fail.
@mwhudson mwhudson mentioned this issue Sep 11, 2015
Closed
@crawshaw crawshaw self-assigned this Sep 11, 2015
@crawshaw
Copy link
Member

I'll take a look at this next week. We probably need to detect whether we are working with Go 1.5 or tip.

@hyangah hyangah mentioned this issue Oct 9, 2015
Closed
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/15803 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 12, 2016
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
@crawshaw
cmd/gomobile: build android stdlib as PIC
300be08 
Fixes golang/go#12581

Change-Id: I9e462b76037f0f89f1d3e59b9aef899d21de925a
Reviewed-on: https://go-review.googlesource.com/15803
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
@crawshaw
cmd/gomobile: build android stdlib as PIC
4c8ea60 
Fixes golang/go#12581

Change-Id: I9e462b76037f0f89f1d3e59b9aef899d21de925a
Reviewed-on: https://go-review.googlesource.com/15803
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crawshaw @mwhudson @gopherbot