Skip to content

Commit

Permalink
runtime: crash on netbsd-arm64 when setcontext fails
Browse files Browse the repository at this point in the history
Instead of exiting with status 16962 when we fail to call SYS_setcontext
in sigreturn, reference a null pointer and crash. Hopefully, this will
enable grabbing a core dump to debug.

Updates #42422

Change-Id: If02c14a0a37084351f3f00db3dc9766cb68ae4b8
Reviewed-on: https://go-review.googlesource.com/c/go/+/375834
Reviewed-by: Tobias Klauser <[email protected]>
Trust: Tobias Klauser <[email protected]>
Trust: Benny Siegert <[email protected]>
  • Loading branch information
bsiegert committed Jan 6, 2022
1 parent b5bfaf4 commit f300fc2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/runtime/sys_netbsd_arm64.s
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,8 @@ fail:
TEXT sigreturn_tramp<>(SB),NOSPLIT,$-8
MOVD g, R0
SVC $SYS_setcontext
MOVD $0x4242, R0 // Something failed, return magic number
SVC $SYS_exit
MOVD $0, R0
MOVD R0, (R0) // crash

TEXT runtime·sigaction(SB),NOSPLIT,$-8
MOVW sig+0(FP), R0 // arg 1 - signum
Expand Down

0 comments on commit f300fc2

Please sign in to comment.