net/http: missing error handling during hijacking

golang · Dec 27, 2024 · a04c13e · a04c13e
1 parent 9f49d26
commit a04c13e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/net/http/server.go b/src/net/http/server.go
@@ -332,7 +332,9 @@ func (c *conn) hijackLocked(w *response) (rwc net.Conn, buf *bufio.ReadWriter, e
 	}
 
 	ccn := &connCloseNotify{rwc: rwc, weakResponse: weak.Make(w)}
-	ccn.attach(c.bufr)
+	if err := ccn.attach(c.bufr); err != nil {
+		return nil, nil, fmt.Errorf("unexpected Peek failure while reattaching buffer: %v", err)
+	}
 	c.bufw.Reset(rwc)
 	buf = bufio.NewReadWriter(c.bufr, c.bufw)