Skip to content

Commit

Permalink
[release-branch.go1.19] cmd/pprof: skip TestDisasm on ARM64
Browse files Browse the repository at this point in the history
The test is fixed at tip, but it is non-trivial enough to backport
to (potentionally the last) Go 1.19 minor release. Skip the test.

Fixes #60637.

Change-Id: I0425b703a5270b680346b63ab38c47b890a3a3bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/501824
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Run-TryBot: Cherry Mui <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
  • Loading branch information
cherrymui authored and gopherbot committed Jun 19, 2023
1 parent 7d6517c commit 606a5a6
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/cmd/pprof/pprof_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ func TestDisasm(t *testing.T) {
mustHaveDisasm(t)
testenv.MustHaveGoBuild(t)

if runtime.GOARCH == "arm64" {
// Fixed at tip (issue 56574). Skip for Go 1.19 release branch.
testenv.SkipFlaky(t, 60637)
}

tmpdir := t.TempDir()
cpuExe := filepath.Join(tmpdir, "cpu.exe")
cmd := exec.Command(testenv.GoToolPath(t), "build", "-o", cpuExe, "cpu.go")
Expand Down

0 comments on commit 606a5a6

Please sign in to comment.