Skip to content

Commit

Permalink
cmd/dist: do not run on ppc64le
Browse files Browse the repository at this point in the history
Also don't run on all the other tiny slow boxes we have.
Should fix the remaining ppc64le broken builders.

For #44505 (or at least somehow provoked by it).

Change-Id: I72e8086cb641f3f7da3a872140a752bf328eec1f
Reviewed-on: https://go-review.googlesource.com/c/go/+/421438
Reviewed-by: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Russ Cox <[email protected]>
Run-TryBot: Russ Cox <[email protected]>
  • Loading branch information
rsc authored and gopherbot committed Aug 5, 2022
1 parent b12366b commit 4fb7e22
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/cmd/dist/test.go
Original file line number Diff line number Diff line change
Expand Up @@ -866,12 +866,12 @@ func (t *tester) registerTests() {
})
}
}
// Only run the API check on fast development platforms. Android, iOS, and JS
// are always cross-compiled, and the filesystems on our only plan9 builders
// are too slow to complete in a reasonable timeframe. Every platform checks
// the API on every GOOS/GOARCH/CGO_ENABLED combination anyway, so we really
// only need to run this check once anywhere to get adequate coverage.
if goos != "android" && !t.iOS() && goos != "js" && goos != "plan9" {
// Only run the API check on fast development platforms.
// Every platform checks the API on every GOOS/GOARCH/CGO_ENABLED combination anyway,
// so we really only need to run this check once anywhere to get adequate coverage.
// To help developers avoid trybot-only failures, we try to run on typical developer machines
// which is darwin/linux/windows and amd64/arm64.
if (goos == "darwin" || goos == "linux" || goos == "windows") && (goarch == "amd64" || goarch == "arm64") {
t.tests = append(t.tests, distTest{
name: "api",
heading: "API check",
Expand Down

0 comments on commit 4fb7e22

Please sign in to comment.