Skip to content
This repository has been archived by the owner on Jan 16, 2021. It is now read-only.

Allow users to set the log level for the root log15 handler. #554

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow users to set the log level for the root log15 handler. #554

wants to merge 1 commit into from

Conversation

parkr
Copy link
Contributor

@parkr parkr commented May 30, 2018

Using the GODOC_LOG_LEVEL environment variable, an administrator running this service
can decide which logs to print. This is helpful for toggling off debugging logs which
may contain sensitive information such as credentials.

If a logger is defined in the context passed into any of the exported logging methods, then this environment variable does not take effect – the handlers specified on the logger in the context determines what is logged and how.

Using the GODOC_LOG_LEVEL environment variable, an administrator running this service
can decide which logs to print. This is helpful for toggling off debugging logs which
may contain sensitive information such as credentials.
@gopherbot
Copy link

This PR (HEAD: b0e939c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/gddo/+/115315 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from David Symonds:

Patch Set 1:

I don't own any of this code.


Please don’t reply on this GitHub thread. Visit golang.org/cl/115315.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Parker Moore:

Patch Set 1:

Patch Set 1:

I don't own any of this code.

Sorry, David! My apologies. You were the only person I saw who had commits in the last 1 month: https://github.com/golang/gddo/pulse/monthly

Do you know who I should ask for review here? ADG?


Please don’t reply on this GitHub thread. Visit golang.org/cl/115315.
After addressing review feedback, remember to publish your drafts!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants