Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

gps: unset some GIT_* variables for git operations #1872

Merged
merged 1 commit into from
Jul 2, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions gps/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

package gps

import (
"os"
)

func (c cmd) Args() []string {
return c.Cmd.Args
}
Expand All @@ -15,3 +19,15 @@ func (c cmd) SetDir(dir string) {
func (c cmd) SetEnv(env []string) {
c.Cmd.Env = env
}

func init() {
// For our git repositories, we very much assume a "regular" topology.
// Therefore, no value for the following variables can be relevant to
// us. Unsetting globally properly propagates to libraries like
// github.com/Masterminds/vcs, which cannot make the same assumption in
// general.
parasiteGitVars := []string{"GIT_DIR", "GIT_INDEX_FILE", "GIT_OBJECT_DIRECTORY", "GIT_WORK_TREE"}
for _, e := range parasiteGitVars {
os.Unsetenv(e)
}
}