-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssh: return unexpected msg error when server fails keyboard-interactive auth early #297
Conversation
This PR (HEAD: 4df2f67) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/590956. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Nicola Murino: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
4df2f67
to
95b457c
Compare
This PR (HEAD: 95b457c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/590956. Important tips:
|
95b457c
to
732afad
Compare
This PR (HEAD: 732afad) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/590956. Important tips:
|
006afc3
to
b5cef16
Compare
This PR (HEAD: b5cef16) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/590956. Important tips:
|
Message from Sami Pönkänen: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
b5cef16
to
28c1119
Compare
This PR (HEAD: 28c1119) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/590956. Important tips:
|
Message from Sami Pönkänen: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
28c1119
to
3197aea
Compare
This PR (HEAD: 3197aea) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/590956. Important tips:
|
3197aea
to
b0e0ee1
Compare
This PR (HEAD: b0e0ee1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/590956. Important tips:
|
Message from Sami Pönkänen: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Ian Lance Taylor: Patch Set 8: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 8: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-29T04:44:17Z","revision":"05fa40fa25835defdf17389e58de831828ad5d97"} Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Ian Lance Taylor: Patch Set 8: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 8: This CL has failed the run. Reason: Tryjob golang/try/x_crypto-gotip-windows-amd64 has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 8: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Nicola Murino: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Nicola Murino: Patch Set 8: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
b0e0ee1
to
f2a8ba2
Compare
This PR (HEAD: f2a8ba2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/590956. Important tips:
|
This PR (HEAD: 4f1243e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/590956. Important tips:
|
Message from Nicola Murino: Patch Set 13: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 13: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-29T14:08:10Z","revision":"abbd9b1b5bb33fde96cf620bbb60bb40349ed5aa"} Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Nicola Murino: Patch Set 13: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 13: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 13: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Nicola Murino: Patch Set 13: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
4f1243e
to
e902116
Compare
This PR (HEAD: e902116) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/590956. Important tips:
|
e902116
to
7fafc4d
Compare
This PR (HEAD: 7fafc4d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/590956. Important tips:
|
Message from Sami Pönkänen: Patch Set 15: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Nicola Murino: Patch Set 15: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Nicola Murino: Patch Set 15: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 15: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-10-15T13:20:26Z","revision":"7caa73b438116475ede4ee66f6813f8b61bb8d37"} Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Nicola Murino: Patch Set 15: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 15: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 15: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Dmitri Shuralyov: Patch Set 15: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Ian Lance Taylor: Patch Set 16: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Ian Lance Taylor: Patch Set 16: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 16: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-10-16T02:36:47Z","revision":"5f5cfd4ef501d97b3bfca21afe6a7ec7f4fecb53"} Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Ian Lance Taylor: Patch Set 16: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 16: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
Message from Go LUCI: Patch Set 16: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/590956. |
…ve auth early Seems the OpenSSH server running on windows fails keyboard-interactive auth this way without sending any prompt to client. In such case the golang ssh client should not retry keyboard-interactive auth when the auth method is wrapped in a RetryableAuthMethod(). Rather the auth method should be immediately marked as tried&failed and the client auth process should move on to next available and acceptable auth method. Fixes golang/go#67855 Change-Id: I6c64ae58ff8325774e37af716601b112f8833d8f GitHub-Last-Rev: 7fafc4d GitHub-Pull-Request: #297 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/590956 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Nicola Murino <[email protected]> Reviewed-by: Nicola Murino <[email protected]>
This PR is being closed because golang.org/cl/590956 has been merged. |
Seems the OpenSSH server running on windows fails keyboard-interactive
auth this way without sending any prompt to client. In such case the
golang ssh client should not retry keyboard-interactive auth when the
auth method is wrapped in a RetryableAuthMethod(). Rather the auth
method should be immediately marked as tried&failed and the client auth
process should move on to next available and acceptable auth method.
Fixes golang/go#67855