-
Notifications
You must be signed in to change notification settings - Fork 154
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
dashboard, cmd/makemac: add macOS 10.15 Catalina builder
Added the macOS 10.15 Catalina builder to the dashboard. Catalina builders should use the Mojave guestid in vSphere 6.7 update 3 because the Catalina guestid is not available in this version of vSphere. A Catalina builder will run on this version of vSphere with the Mojave guestid. Modified the expected number of vm instances running on Macstadium due to the addition of macOS 10.15 builders. Updates golang/go#34748 Change-Id: If14f6e088afc05dd1783460f21907e9345e3c338 Reviewed-on: https://go-review.googlesource.com/c/build/+/207937 Reviewed-by: Brad Fitzpatrick <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
- Loading branch information
1 parent
6191a53
commit d6dec9c
Showing
3 changed files
with
43 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -472,6 +472,7 @@ func TestBuilderConfig(t *testing.T) { | |
{b("windows-386-2008", "exp"), both}, | ||
{b("windows-amd64-2016", "exp"), both}, | ||
{b("darwin-amd64-10_14", "exp"), onlyPost}, | ||
{b("darwin-amd64-10_15", "exp"), onlyPost}, | ||
// ... but not on most others: | ||
{b("darwin-amd64-10_12", "exp"), none}, | ||
{b("freebsd-386-11_2", "exp"), none}, | ||
|
@@ -494,6 +495,7 @@ func TestBuilderConfig(t *testing.T) { | |
{b("[email protected]", "net"), none}, | ||
{b("[email protected]", "net"), none}, | ||
|
||
{b("darwin-amd64-10_15", "go"), onlyPost}, | ||
{b("darwin-amd64-10_14", "go"), onlyPost}, | ||
{b("darwin-amd64-10_12", "go"), onlyPost}, | ||
{b("darwin-amd64-10_11", "go"), onlyPost}, | ||
|
@@ -615,10 +617,10 @@ func TestShouldRunDistTest(t *testing.T) { | |
{"darwin-amd64-10_11", "test:foo", postSubmit, false}, | ||
{"darwin-amd64-10_12", "test:foo", postSubmit, false}, | ||
{"darwin-amd64-10_14", "test:foo", postSubmit, false}, | ||
{"darwin-amd64-10_14", "test:foo", postSubmit, false}, | ||
{"darwin-amd64-10_14", "reboot", postSubmit, false}, | ||
{"darwin-amd64-10_14", "api", postSubmit, false}, | ||
{"darwin-amd64-10_14", "codewalk", postSubmit, false}, | ||
{"darwin-amd64-10_15", "test:foo", postSubmit, false}, | ||
} | ||
for _, tt := range tests { | ||
bc, ok := Builders[tt.builder] | ||
|
@@ -803,3 +805,18 @@ func TestTryBotsCompileAllPorts(t *testing.T) { | |
} | ||
|
||
} | ||
|
||
// TestExpectedMacstadiumVMCount ensures that only 20 instances of macOS virtual machines | ||
// are expected at MacStadium. | ||
// TODO: remove once the scheduler allocates VMs based on demand https://golang.org/issue/35698 | ||
func TestExpectedMacstadiumVMCount(t *testing.T) { | ||
got := 0 | ||
for host, config := range Hosts { | ||
if strings.HasPrefix(host, "host-darwin-10_") { | ||
got += config.ExpectNum | ||
} | ||
} | ||
if got != 20 { | ||
t.Fatalf("macstadium host count: got %d; want 20", got) | ||
} | ||
} |