Skip to content

Commit

Permalink
main.star: run longetst builders in presubmit if cmd/go is modified
Browse files Browse the repository at this point in the history
This CL will cause longetst builders to be run if code in src/cmd/go is
modified. There are many cmd/go tests that are skipped in short mode so
only running the short tests by default leaves out a lot of coverage.

Fixes golang/go#42661

Change-Id: Idd0b86220cf53560eb2ad6b6877b9431731377b9
Reviewed-on: https://go-review.googlesource.com/c/build/+/648275
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
  • Loading branch information
matloob committed Feb 14, 2025
1 parent c0d7a64 commit c5a08f8
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 0 deletions.
36 changes: 36 additions & 0 deletions generated/commit-queue.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -13741,6 +13741,12 @@ config_groups {
gerrit_ref_regexp: ".*"
path_regexp: "src/crypto/tls/.+"
}
location_filters {
gerrit_host_regexp: "go-review.googlesource.com"
gerrit_project_regexp: "^go$"
gerrit_ref_regexp: ".*"
path_regexp: "src/cmd/go/.+"
}
}
builders {
name: "golang/try/gotip-linux-386-softfloat"
Expand Down Expand Up @@ -13801,6 +13807,12 @@ config_groups {
gerrit_ref_regexp: ".*"
path_regexp: "src/crypto/tls/.+"
}
location_filters {
gerrit_host_regexp: "go-review.googlesource.com"
gerrit_project_regexp: "^go$"
gerrit_ref_regexp: ".*"
path_regexp: "src/cmd/go/.+"
}
}
builders {
name: "golang/try/gotip-linux-amd64-longtest-aliastypeparams"
Expand Down Expand Up @@ -13829,6 +13841,12 @@ config_groups {
gerrit_ref_regexp: ".*"
path_regexp: "src/crypto/tls/.+"
}
location_filters {
gerrit_host_regexp: "go-review.googlesource.com"
gerrit_project_regexp: "^go$"
gerrit_ref_regexp: ".*"
path_regexp: "src/cmd/go/.+"
}
}
builders {
name: "golang/try/gotip-linux-amd64-longtest-noswissmap"
Expand Down Expand Up @@ -13862,6 +13880,12 @@ config_groups {
gerrit_ref_regexp: ".*"
path_regexp: "src/crypto/tls/.+"
}
location_filters {
gerrit_host_regexp: "go-review.googlesource.com"
gerrit_project_regexp: "^go$"
gerrit_ref_regexp: ".*"
path_regexp: "src/cmd/go/.+"
}
}
builders {
name: "golang/try/gotip-linux-amd64-misccompile"
Expand Down Expand Up @@ -14019,6 +14043,12 @@ config_groups {
gerrit_ref_regexp: ".*"
path_regexp: "src/crypto/tls/.+"
}
location_filters {
gerrit_host_regexp: "go-review.googlesource.com"
gerrit_project_regexp: "^go$"
gerrit_ref_regexp: ".*"
path_regexp: "src/cmd/go/.+"
}
}
builders {
name: "golang/try/gotip-linux-arm64-race"
Expand Down Expand Up @@ -14188,6 +14218,12 @@ config_groups {
gerrit_ref_regexp: ".*"
path_regexp: "src/crypto/tls/.+"
}
location_filters {
gerrit_host_regexp: "go-review.googlesource.com"
gerrit_project_regexp: "^go$"
gerrit_ref_regexp: ".*"
path_regexp: "src/cmd/go/.+"
}
}
builders {
name: "golang/try/gotip-windows-amd64-race"
Expand Down
3 changes: 3 additions & 0 deletions main.star
Original file line number Diff line number Diff line change
Expand Up @@ -1011,6 +1011,9 @@ RUN_MODS = dict(
# Enable longtest builders on go against tip if files in the crypto/tls tree are modified,
# so that the BoGo test suite is run.
"src/crypto/tls/.+",
# Enable longtest builders on go against tip if files in the cmd/go tree are modified,
# so the many cmd/go script tests that are skipped on short are run.
"src/cmd/go/.+",
],
"protobuf": [],
}),
Expand Down

0 comments on commit c5a08f8

Please sign in to comment.