Skip to content

Commit

Permalink
cmd/coordinator: give reverse buildlets 20 seconds during health check
Browse files Browse the repository at this point in the history
Some reverse builders may be further away geographically, so waiting
only 5 seconds (a time chosen in 2015) before concluding the buildlet
is unhealthy seems short. Give them a bit more time to accommodate for
round-trip network trip and processing latency.

Change-Id: I707c430538b2f19115e9b9dd78ec6aaeb64c4270
Reviewed-on: https://go-review.googlesource.com/c/build/+/406215
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
  • Loading branch information
dmitshur committed May 16, 2022
1 parent dd8f4a3 commit acd0c19
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/coordinator/pool/reverse.go
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ func (p *ReverseBuildletPool) healthCheckBuildlet(b *reverseBuildlet) bool {
}()
p.mu.Unlock()

t := time.NewTimer(5 * time.Second) // give buildlets time to respond
t := time.NewTimer(20 * time.Second) // give buildlets time to respond
var err error
select {
case err = <-res:
Expand Down

0 comments on commit acd0c19

Please sign in to comment.