Skip to content

Commit

Permalink
main.star: enable linux-amd64-typesalias presubmit for Go 1.23 and tip
Browse files Browse the repository at this point in the history
This is separated out in a separate CL for a more gradual rollout.

Fixes golang/go#68798.

Change-Id: I6a4c2f1e89ab7c6426a9b5d19e429b68ca61bee4
Reviewed-on: https://go-review.googlesource.com/c/build/+/604336
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Tim King <[email protected]>
Reviewed-by: David Chase <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
  • Loading branch information
dmitshur authored and gopherbot committed Aug 9, 2024
1 parent 9e8a03b commit 8cb2bf7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions generated/commit-queue.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -29131,7 +29131,6 @@ config_groups {
}
builders {
name: "golang/try/go1.23-linux-amd64-typesalias"
includable_only: true
disable_reuse: true
}
builders {
Expand Down Expand Up @@ -29993,7 +29992,6 @@ config_groups {
}
builders {
name: "golang/try/gotip-linux-amd64-typesalias"
includable_only: true
disable_reuse: true
}
builders {
Expand Down Expand Up @@ -86645,7 +86643,6 @@ config_groups {
}
builders {
name: "golang/try/x_tools-go1.23-linux-amd64-typesalias"
includable_only: true
disable_reuse: true
}
builders {
Expand Down Expand Up @@ -88087,7 +88084,6 @@ config_groups {
}
builders {
name: "golang/try/x_tools-gotip-linux-amd64-typesalias"
includable_only: true
disable_reuse: true
}
builders {
Expand Down
2 changes: 1 addition & 1 deletion main.star
Original file line number Diff line number Diff line change
Expand Up @@ -810,7 +810,7 @@ def define_for_issue68798():
# Starting with Go 1.23, gotypesalias=1 is the default, so
# a builder that sets it explicitly in the environment is expected to be a no-op.
# Run it anyway to confirm that's the case for reasons motivated in go.dev/issue/68798.
presubmit, postsubmit = False, True
presubmit, postsubmit = True, True
return (exists, presubmit, postsubmit, [])

return f
Expand Down

0 comments on commit 8cb2bf7

Please sign in to comment.