Skip to content

Commit

Permalink
dashboard: shard openbsd-amd64-68 TryBot also
Browse files Browse the repository at this point in the history
The goal in CL 279512 was to reduce numTryTestHelpers from 5 to 4,
but it unintentionally set the field only in the 386 builder, not
the amd64 one. This caused the amd64 OpenBSD TryBot to get very
slow (20-25 minutes), making it very much a bottleneck for overall
TryBot completion time.

Also stop explicitly setting some fields in openbsd-amd64-62
builder that have no effect by now, to simplify configuration.

For golang/go#17104.
Updates golang/go#35712.

Change-Id: I22823e4848cab65f11bde2a1cc70527929d0792d
Reviewed-on: https://go-review.googlesource.com/c/build/+/279723
Trust: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
  • Loading branch information
dmitshur committed Dec 23, 2020
1 parent 7d700e0 commit 0a4bf69
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions dashboard/builders.go
Original file line number Diff line number Diff line change
Expand Up @@ -2019,14 +2019,11 @@ func init() {
Name: "openbsd-amd64-62",
HostType: "host-openbsd-amd64-62",
distTestAdjust: noTestDirAndNoReboot,
tryBot: nil,
buildsRepo: func(repo, branch, goBranch string) bool {
// This builder is unfortunately still used by Go 1.15 and 1.14,
// so keep it around a bit longer. See golang.org/issue/42426.
return atMostGo1(goBranch, 15) && buildRepoByDefault(repo)
},
numTestHelpers: 0,
numTryTestHelpers: 5,
})
addBuilder(BuildConfig{
Name: "openbsd-amd64-64",
Expand All @@ -2040,10 +2037,11 @@ func init() {
distTestAdjust: noTestDirAndNoReboot,
})
addBuilder(BuildConfig{
Name: "openbsd-amd64-68",
HostType: "host-openbsd-amd64-68",
tryBot: defaultTrySet(),
distTestAdjust: noTestDirAndNoReboot,
Name: "openbsd-amd64-68",
HostType: "host-openbsd-amd64-68",
tryBot: defaultTrySet(),
distTestAdjust: noTestDirAndNoReboot,
numTryTestHelpers: 4,
})
addBuilder(BuildConfig{
Name: "openbsd-386-68",
Expand Down

0 comments on commit 0a4bf69

Please sign in to comment.